Failing when a segment is not found is very bad for the Engine

carlosdelest · carlosdelest · commit 229967d19a2e · 2025-02-14T10:38:30.000+01:00
diff --git a/server/src/main/java/org/elasticsearch/index/engine/SegmentMergeMemoryEstimator.java b/server/src/main/java/org/elasticsearch/index/engine/SegmentMergeMemoryEstimator.java
@@ -45,7 +45,8 @@ private static long estimateSegmentMemory(String segmentName, IndexReader indexR
             }
         }
 
-        throw new IllegalArgumentException("Segment not found: " + segmentName);
+        // Segment not found, we can't estimate it
+        return 0;
     }
 
     private static long estimateSegmentMemory(SegmentReader reader) {

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,8 @@ private static long estimateSegmentMemory(String segmentName, IndexReader indexR`
`45`	`45`	`}`
`46`	`46`	`}`
`47`	`47`
`48`		`- throw new IllegalArgumentException("Segment not found: " + segmentName);`
	`48`	`+ // Segment not found, we can't estimate it`
	`49`	`+ return 0;`
`49`	`50`	`}`
`50`	`51`
`51`	`52`	`private static long estimateSegmentMemory(SegmentReader reader) {`