Skip to content

Commit 257b75d

Browse files
committed
Add tests
1 parent 0dab8ea commit 257b75d

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

server/src/main/java/org/elasticsearch/search/vectors/RescoreVectorBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
public class RescoreVectorBuilder implements Writeable, ToXContentObject {
2525

2626
public static final ParseField OVERSAMPLE_FIELD = new ParseField("oversample");
27-
public static final int MIN_OVERSAMPLE = 1;
27+
public static final float MIN_OVERSAMPLE = 1.0F;
2828
private static final ConstructingObjectParser<RescoreVectorBuilder, Void> PARSER = new ConstructingObjectParser<>(
2929
"rescore",
3030
args -> new RescoreVectorBuilder((Float) args[0])

server/src/test/java/org/elasticsearch/search/vectors/KnnSearchBuilderTests.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,14 @@ public void testInvalidK() {
254254
assertThat(e.getMessage(), containsString("[k] must be greater than 0"));
255255
}
256256

257+
public void testInvalidRescoreVectorBuilder() {
258+
IllegalArgumentException e = expectThrows(
259+
IllegalArgumentException.class,
260+
() -> new KnnSearchBuilder("field", randomVector(3), 0, 100, new RescoreVectorBuilder(1.0F), null)
261+
);
262+
assertThat(e.getMessage(), containsString("[oversample] must be > 1.0"));
263+
}
264+
257265
public void testRewrite() throws Exception {
258266
float[] expectedArray = randomVector(randomIntBetween(10, 1024));
259267
RescoreVectorBuilder expectedRescore = new RescoreVectorBuilder(randomFloatBetween(1.0f, 10.0f, false));

0 commit comments

Comments
 (0)