Skip to content

Commit 3ec689d

Browse files
committed
Remove (optional) from docs rendering as it impacts many other functions
1 parent 9da584c commit 3ec689d

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

docs/reference/esql/functions/types/match.asciidoc

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/AbstractFunctionTestCase.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -960,11 +960,8 @@ protected static void renderDocs(String name) throws IOException {
960960
private static void renderTypes(String name, List<EsqlFunctionRegistry.ArgSignature> args) throws IOException {
961961
StringBuilder header = new StringBuilder();
962962
List<String> argNames = args.stream().map(EsqlFunctionRegistry.ArgSignature::name).toList();
963-
for (EsqlFunctionRegistry.ArgSignature arg : args) {
964-
if (arg.optional()) {
965-
header.append("(optional) ");
966-
}
967-
header.append(arg.name()).append(" | ");
963+
for (String arg : argNames) {
964+
header.append(arg).append(" | ");
968965
}
969966
header.append("result");
970967

0 commit comments

Comments
 (0)