Skip to content

Commit 62b0d1c

Browse files
committed
Remove TransportVersion as knn is not released yet
1 parent 7ebd1d9 commit 62b0d1c

File tree

2 files changed

+2
-9
lines changed
  • server/src/main/java/org/elasticsearch
  • x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/vector

2 files changed

+2
-9
lines changed

server/src/main/java/org/elasticsearch/TransportVersions.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,6 @@ static TransportVersion def(int id) {
337337
public static final TransportVersion ML_INFERENCE_CUSTOM_SERVICE_EMBEDDING_TYPE = def(9_118_0_00);
338338
public static final TransportVersion ESQL_FIXED_INDEX_LIKE = def(9_119_0_00);
339339
public static final TransportVersion LOOKUP_JOIN_CCS = def(9_120_0_00);
340-
public static final TransportVersion ESQL_KNN_FUNCTION_PREFILTER = def(9_121_0_00);
341340

342341
/*
343342
* STOP! READ THIS FIRST! No, really,

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/vector/Knn.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
package org.elasticsearch.xpack.esql.expression.function.vector;
99

10-
import org.elasticsearch.TransportVersions;
1110
import org.elasticsearch.common.io.stream.NamedWriteableRegistry;
1211
import org.elasticsearch.common.io.stream.StreamInput;
1312
import org.elasticsearch.common.io.stream.StreamOutput;
@@ -349,10 +348,7 @@ private static Knn readFrom(StreamInput in) throws IOException {
349348
Expression field = in.readNamedWriteable(Expression.class);
350349
Expression query = in.readNamedWriteable(Expression.class);
351350
QueryBuilder queryBuilder = in.readOptionalNamedWriteable(QueryBuilder.class);
352-
List<Expression> filterExpressions = List.of();
353-
if (in.getTransportVersion().onOrAfter(TransportVersions.ESQL_KNN_FUNCTION_PREFILTER)) {
354-
filterExpressions = in.readNamedWriteableCollectionAsList(Expression.class);
355-
}
351+
List<Expression> filterExpressions = in.readNamedWriteableCollectionAsList(Expression.class);
356352
return new Knn(source, field, query, null, null, queryBuilder, filterExpressions);
357353
}
358354

@@ -362,9 +358,7 @@ public void writeTo(StreamOutput out) throws IOException {
362358
out.writeNamedWriteable(field());
363359
out.writeNamedWriteable(query());
364360
out.writeOptionalNamedWriteable(queryBuilder());
365-
if (out.getTransportVersion().onOrAfter(TransportVersions.ESQL_KNN_FUNCTION_PREFILTER)) {
366-
out.writeNamedWriteableCollection(filterExpressions());
367-
}
361+
out.writeNamedWriteableCollection(filterExpressions());
368362
}
369363

370364
@Override

0 commit comments

Comments
 (0)