Commit 7380179
authored
[ESQL] Shortcircuit grouping aggs on null value (elastic#129708)
Minor aggregators change plus a test to ensure we check that code path.
We were doing a `value.isNull()` for each group the value had to be aggregated in, instead of doing it just once at the beginning.
The affectation goes as follows:
- 1 group, null value: We avoid some extra lightweight calls
- N groups, null value: We avoid calling it N times
- No groups, or non-null value: No effect1 parent 9e81541 commit 7380179
File tree
82 files changed
+276
-726
lines changed- x-pack/plugin/esql/compute
- gen/src/main/java/org/elasticsearch/compute/gen
- src
- main
- generated/org/elasticsearch/compute/aggregation
- spatial
- java/org/elasticsearch/compute/aggregation
- test/java/org/elasticsearch/compute
- aggregation
- data
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
82 files changed
+276
-726
lines changedLines changed: 9 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
411 | 412 | | |
412 | 413 | | |
413 | 414 | | |
414 | | - | |
415 | | - | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
416 | 421 | | |
417 | 422 | | |
| 423 | + | |
| 424 | + | |
418 | 425 | | |
419 | 426 | | |
420 | 427 | | |
| |||
430 | 437 | | |
431 | 438 | | |
432 | 439 | | |
433 | | - | |
434 | | - | |
435 | | - | |
436 | 440 | | |
437 | 441 | | |
438 | 442 | | |
| |||
Lines changed: 3 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 3 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 3 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 3 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 3 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 3 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments