Fix IndicesService building related to search operation listeners

Author: carlosdelest

server/src/main/java/org/elasticsearch/index/IndexModule.java

@@ -478,8 +478,7 @@ public IndexService newIndexService(
         IdFieldMapper idFieldMapper,
         ValuesSourceRegistry valuesSourceRegistry,
         IndexStorePlugin.IndexFoldersDeletionListener indexFoldersDeletionListener,
-        Map<String, IndexStorePlugin.SnapshotCommitSupplier> snapshotCommitSuppliers,
-        List<SearchOperationListener> searchOperationListeners
+        Map<String, IndexStorePlugin.SnapshotCommitSupplier> snapshotCommitSuppliers
     ) throws IOException {
         final IndexEventListener eventListener = freeze();
         Function<IndexService, CheckedFunction<DirectoryReader, DirectoryReader, IOException>> readerWrapperFactory = indexReaderWrapper

server/src/main/java/org/elasticsearch/indices/IndicesService.java

@@ -782,8 +782,7 @@ private synchronized IndexService createIndexService(
             idFieldMappers.apply(idxSettings.getMode()),
             valuesSourceRegistry,
             indexFoldersDeletionListeners,
-            snapshotCommitSuppliers,
-            searchOperationListeners
+            snapshotCommitSuppliers
         );
     }
 

server/src/main/java/org/elasticsearch/indices/IndicesServiceBuilder.java

@@ -75,7 +75,7 @@ public class IndicesServiceBuilder {
     @Nullable
     CheckedBiConsumer<ShardSearchRequest, StreamOutput, IOException> requestCacheKeyDifferentiator;
     MapperMetrics mapperMetrics;
-    List<SearchOperationListener> searchOperationListener;
+    List<SearchOperationListener> searchOperationListener = List.of();
 
     public IndicesServiceBuilder settings(Settings settings) {
         this.settings = settings;

server/src/test/java/org/elasticsearch/index/IndexModuleTests.java

@@ -223,8 +223,7 @@ private IndexService newIndexService(IndexModule module) throws IOException {
             module.indexSettings().getMode().idFieldMapperWithoutFieldData(),
             null,
             indexDeletionListener,
-            emptyMap(),
-            emptyList()
+            emptyMap()
         );
     }