Merge remote-tracking branch 'carlosdelest/non-issue/esql-function-loaders-pushdown-testing' into non-issue/esql-function-loaders-pushdown-testing

Author: elasticsearchmachine

x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/PushExpressionToLoadIT.java

@@ -372,7 +372,8 @@ public void testVHammingToBit() throws IOException {
     //
     public void testLengthPushedWithoutTopN() throws IOException {
         String textValue = "v".repeat(between(0, 256));
-        test(b -> b.startObject("test").field("type", "keyword").endObject(),
+        test(
+            b -> b.startObject("test").field("type", "keyword").endObject(),
             b -> b.field("test", textValue),
             """
                 FROM test
@@ -381,8 +382,7 @@ public void testLengthPushedWithoutTopN() throws IOException {
                 | KEEP test, fieldLength
                 """,
             matchesList().item(textValue).item(textValue.length()),
-            matchesList()
-                .item(matchesMap().entry("name", "test").entry("type", any(String.class)))
+            matchesList().item(matchesMap().entry("name", "test").entry("type", any(String.class)))
                 .item(matchesMap().entry("name", "fieldLength").entry("type", any(String.class))),
             Map.of(
                 "data",
@@ -401,9 +401,9 @@ public void testLengthPushedWithTopN() throws IOException {
         String textValue = "v".repeat(between(0, 256));
         Integer orderingValue = randomInt();
         test(b -> {
-                b.startObject("test").field("type", "keyword").endObject();
-                b.startObject("ordering").field("type", "integer").endObject();
-            },
+            b.startObject("test").field("type", "keyword").endObject();
+            b.startObject("ordering").field("type", "integer").endObject();
+        },
             b -> b.field("test", textValue).field("ordering", orderingValue),
             """
                 FROM test
@@ -416,9 +416,7 @@ public void testLengthPushedWithTopN() throws IOException {
             matchesList().item(matchesMap().entry("name", "test").entry("type", any(String.class))),
             Map.of(
                 "data",
-                List.of(
-                    matchesMap().entry("ordering:column_at_a_time:IntsFromDocValues.Singleton", 1)
-                ),
+                List.of(matchesMap().entry("ordering:column_at_a_time:IntsFromDocValues.Singleton", 1)),
                 "node_reduce",
                 List.of(
                     // Pushed down function
@@ -434,7 +432,8 @@ public void testLengthPushedWithTopN() throws IOException {
     public void testLengthPushedWithTopNAsOrder() throws IOException {
         String textValue = "v".repeat(between(0, 256));
         Integer orderingValue = randomInt();
-        test(b ->  b.startObject("test").field("type", "keyword").endObject(),
+        test(
+            b -> b.startObject("test").field("type", "keyword").endObject(),
             b -> b.field("test", textValue).field("ordering", orderingValue),
             """
                 FROM test
@@ -737,12 +736,19 @@ private void test(
         Consumer<List<String>> assertDataNodeSig
     ) throws IOException {
 
-        test(mapping, doc, """
-            FROM test
-            """ + eval + """
-            | STATS test = MV_SORT(VALUES(test))
-            """, expectedValue, matchesList().item(matchesMap().entry("name", "test").entry("type", any(String.class))),
-            Map.of("data", List.of(expectedLoaders)), assertDataNodeSig);
+        test(
+            mapping,
+            doc,
+            """
+                FROM test
+                """ + eval + """
+                | STATS test = MV_SORT(VALUES(test))
+                """,
+            expectedValue,
+            matchesList().item(matchesMap().entry("name", "test").entry("type", any(String.class))),
+            Map.of("data", List.of(expectedLoaders)),
+            assertDataNodeSig
+        );
     }
 
     private void test(

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/LocalLogicalPlanOptimizerTests.java

@@ -1927,7 +1927,8 @@ public void testReductionPlanForTopNWithPushedDownFunctions() {
         // Eval[[$$dense_vector$V_DOT_PRODUCT$1451583510{f$}#1110 AS score#1085]]
         var eval = as(topN.child(), Eval.class);
         assertThat(eval.fields(), hasSize(1));
-        var scoreAlias = eval.fields().stream()
+        var scoreAlias = eval.fields()
+            .stream()
             .filter(f -> f.name().equals("score"))
             .findFirst()
             .orElseThrow(() -> new AssertionError("Field 'score' not found in eval"));