Skip to content

Commit cdfaa07

Browse files
committed
Spotless
1 parent 2f87f2f commit cdfaa07

File tree

4 files changed

+31
-24
lines changed

4 files changed

+31
-24
lines changed

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/Match.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public class Match extends FullTextFunction implements Validatable, OptionalArgu
128128
entry(Fuzziness.FIELD.getPreferredName(), KEYWORD),
129129
entry(BOOST_FIELD.getPreferredName(), FLOAT),
130130
entry(FUZZY_TRANSPOSITIONS_FIELD.getPreferredName(), BOOLEAN),
131-
entry(FUZZY_REWRITE_FIELD.getPreferredName(), KEYWORD),
131+
entry(FUZZY_REWRITE_FIELD.getPreferredName(), KEYWORD),
132132
entry(LENIENT_FIELD.getPreferredName(), BOOLEAN),
133133
entry(MAX_EXPANSIONS_FIELD.getPreferredName(), INTEGER),
134134
entry(MINIMUM_SHOULD_MATCH_FIELD.getPreferredName(), KEYWORD),
@@ -169,7 +169,7 @@ public Match(
169169
optional = true
170170
) Expression options
171171
) {
172-
this(source, field, matchQuery, options,null);
172+
this(source, field, matchQuery, options, null);
173173
}
174174

175175
public Match(Source source, Expression field, Expression matchQuery, Expression options, QueryBuilder queryBuilder) {
@@ -267,13 +267,7 @@ private Map<String, Object> parseOptions() throws InvalidArgumentException {
267267
DataType dataType = ALLOWED_OPTIONS.get(optionName);
268268
if (dataType == null) {
269269
throw new InvalidArgumentException(
270-
format(
271-
null,
272-
"Invalid option [{}] in [{}], expected one of {}",
273-
optionName,
274-
sourceText(),
275-
ALLOWED_OPTIONS.keySet()
276-
)
270+
format(null, "Invalid option [{}] in [{}], expected one of {}", optionName, sourceText(), ALLOWED_OPTIONS.keySet())
277271
);
278272
}
279273
try {

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/querydsl/query/MatchQuery.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,16 +38,16 @@ public class MatchQuery extends Query {
3838
// appliers.put("zero_terms_query", (qb, s) -> qb.zeroTermsQuery(s));
3939
BUILDER_APPLIERS = Map.ofEntries(
4040
entry(ANALYZER_FIELD.getPreferredName(), (qb, s) -> qb.analyzer(s.toString())),
41-
entry(GENERATE_SYNONYMS_PHRASE_QUERY.getPreferredName(), (qb, b) -> qb.autoGenerateSynonymsPhraseQuery((Boolean)b)),
41+
entry(GENERATE_SYNONYMS_PHRASE_QUERY.getPreferredName(), (qb, b) -> qb.autoGenerateSynonymsPhraseQuery((Boolean) b)),
4242
entry(Fuzziness.FIELD.getPreferredName(), (qb, s) -> qb.fuzziness(Fuzziness.fromString(s.toString()))),
43-
entry(AbstractQueryBuilder.BOOST_FIELD.getPreferredName(), (qb, s) -> qb.boost((Float)s)),
44-
entry(FUZZY_TRANSPOSITIONS_FIELD.getPreferredName(), (qb, s) -> qb.fuzzyTranspositions((Boolean)s)),
45-
entry(FUZZY_REWRITE_FIELD.getPreferredName(), (qb, s) -> qb.fuzzyRewrite(s.toString())),
46-
entry(MatchQueryBuilder.LENIENT_FIELD.getPreferredName(), (qb, s) -> qb.lenient((Boolean)s)),
47-
entry(MAX_EXPANSIONS_FIELD.getPreferredName(), (qb, s) -> qb.maxExpansions((Integer)s)),
43+
entry(AbstractQueryBuilder.BOOST_FIELD.getPreferredName(), (qb, s) -> qb.boost((Float) s)),
44+
entry(FUZZY_TRANSPOSITIONS_FIELD.getPreferredName(), (qb, s) -> qb.fuzzyTranspositions((Boolean) s)),
45+
entry(FUZZY_REWRITE_FIELD.getPreferredName(), (qb, s) -> qb.fuzzyRewrite(s.toString())),
46+
entry(MatchQueryBuilder.LENIENT_FIELD.getPreferredName(), (qb, s) -> qb.lenient((Boolean) s)),
47+
entry(MAX_EXPANSIONS_FIELD.getPreferredName(), (qb, s) -> qb.maxExpansions((Integer) s)),
4848
entry(MINIMUM_SHOULD_MATCH_FIELD.getPreferredName(), (qb, s) -> qb.minimumShouldMatch(s.toString())),
4949
entry(OPERATOR_FIELD.getPreferredName(), (qb, s) -> qb.operator(Operator.fromString(s.toString()))),
50-
entry(PREFIX_LENGTH_FIELD.getPreferredName(), (qb, s) -> qb.prefixLength((Integer)s))
50+
entry(PREFIX_LENGTH_FIELD.getPreferredName(), (qb, s) -> qb.prefixLength((Integer) s))
5151
);
5252
}
5353

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2025,8 +2025,12 @@ public void testMatchOptions() {
20252025

20262026
// Check all data types for available options
20272027
DataType[] optionTypes = new DataType[] {
2028-
DataType.INTEGER, DataType.LONG, DataType.FLOAT, DataType.DOUBLE, DataType.KEYWORD, DataType.BOOLEAN
2029-
};
2028+
DataType.INTEGER,
2029+
DataType.LONG,
2030+
DataType.FLOAT,
2031+
DataType.DOUBLE,
2032+
DataType.KEYWORD,
2033+
DataType.BOOLEAN };
20302034
for (Map.Entry<String, DataType> allowedOptions : Match.ALLOWED_OPTIONS.entrySet()) {
20312035
String optionName = allowedOptions.getKey();
20322036
DataType optionType = allowedOptions.getValue();
@@ -2052,8 +2056,17 @@ public void testMatchOptions() {
20522056
query(query);
20532057
} catch (InvalidArgumentException e) {
20542058
assertEquals(
2055-
"1:19: Invalid option [" + optionName + "] in [match(first_name, \"Jean\", {\"" + optionName + "\": "
2056-
+ queryOptionValue + "})], cannot cast [" + optionValue + "] to [" + optionType.typeName() + "]",
2059+
"1:19: Invalid option ["
2060+
+ optionName
2061+
+ "] in [match(first_name, \"Jean\", {\""
2062+
+ optionName
2063+
+ "\": "
2064+
+ queryOptionValue
2065+
+ "})], cannot cast ["
2066+
+ optionValue
2067+
+ "] to ["
2068+
+ optionType.typeName()
2069+
+ "]",
20572070
error(query)
20582071
);
20592072
}
@@ -2062,8 +2075,9 @@ public void testMatchOptions() {
20622075

20632076
assertThat(
20642077
error("FROM test | WHERE match(first_name, \"Jean\", {\"unknown_option\": true})"),
2065-
containsString("1:19: Invalid option [unknown_option] in [match(first_name, \"Jean\", {\"unknown_option\": true})]," +
2066-
" expected one of ")
2078+
containsString(
2079+
"1:19: Invalid option [unknown_option] in [match(first_name, \"Jean\", {\"unknown_option\": true})]," + " expected one of "
2080+
)
20672081
);
20682082
}
20692083

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/LocalPhysicalPlanOptimizerTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1593,8 +1593,7 @@ public void testMatchOptionsPushDown() {
15931593
var actualLuceneQuery = as(fieldExtract.child(), EsQueryExec.class).query();
15941594

15951595
Source filterSource = new Source(4, 8, "emp_no > 10000");
1596-
var expectedLuceneQuery = new MatchQueryBuilder("first_name", "Anna")
1597-
.fuzziness(Fuzziness.AUTO)
1596+
var expectedLuceneQuery = new MatchQueryBuilder("first_name", "Anna").fuzziness(Fuzziness.AUTO)
15981597
.prefixLength(3)
15991598
.maxExpansions(10)
16001599
.fuzzyTranspositions(false)

0 commit comments

Comments
 (0)