Fix release tests for semantic_text (elastic#116202)

ioanatia · web-flow · commit eef2ba43f6d4 · 2024-11-05T10:43:38.000+01:00
diff --git a/x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/type/DataType.java b/x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/type/DataType.java
@@ -370,10 +370,7 @@ public static boolean isUnsupported(DataType from) {
     }
 
     public static boolean isString(DataType t) {
-        if (EsqlCorePlugin.SEMANTIC_TEXT_FEATURE_FLAG.isEnabled() && t == SEMANTIC_TEXT) {
-            return true;
-        }
-        return t == KEYWORD || t == TEXT;
+        return t == KEYWORD || t == TEXT || t == SEMANTIC_TEXT;
     }
 
     public static boolean isPrimitiveAndSupported(DataType t) {

Original file line number	Diff line number	Diff line change
`@@ -370,10 +370,7 @@ public static boolean isUnsupported(DataType from) {`
`370`	`370`	`}`
`371`	`371`
`372`	`372`	`public static boolean isString(DataType t) {`
`373`		`- if (EsqlCorePlugin.SEMANTIC_TEXT_FEATURE_FLAG.isEnabled() && t == SEMANTIC_TEXT) {`
`374`		`- return true;`
`375`		`- }`
`376`		`- return t == KEYWORD \|\| t == TEXT;`
	`373`	`+ return t == KEYWORD \|\| t == TEXT \|\| t == SEMANTIC_TEXT;`
`377`	`374`	`}`
`378`	`375`
`379`	`376`	`public static boolean isPrimitiveAndSupported(DataType t) {`