Skip to content

Commit 65e7f13

Browse files
committed
plugin review fixes per the guidelines
1 parent cb54c7b commit 65e7f13

File tree

1 file changed

+2
-25
lines changed

1 file changed

+2
-25
lines changed

src/main.ts

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,6 @@ import { Extension, ExtensionApi } from './extension-api';
33
import { ExtensionApiImpl, InternalExtensionWrapper } from "./extension-impl";
44
import { Settings, SettingsTab } from './settings';
55

6-
// Remember to rename these classes and interfaces!
7-
8-
// REMOVE
9-
interface MyPluginSettings {
10-
mySetting: string;
11-
}
12-
136
const DEFAULT_SETTINGS: Settings = {
147
extensionFolder: 'Extensions'
158
}
@@ -157,7 +150,7 @@ export default class ExtensionPlugin extends Plugin {
157150
return;
158151
}
159152

160-
var extName = `New Extension`;
153+
let extName = `New Extension`;
161154
const extDesc = 'Brand new extension';
162155
const extContent = `{
163156
name: "${extName}",
@@ -172,7 +165,7 @@ export default class ExtensionPlugin extends Plugin {
172165
`;
173166

174167
// if the file already exists
175-
var idx = 1;
168+
let idx = 1;
176169
while(this.app.vault.getFileByPath(`${extDir.path}/${extName}.js`)) {
177170
extName = `${extName}-${idx++}`;
178171
}
@@ -204,19 +197,3 @@ export default class ExtensionPlugin extends Plugin {
204197
await this.saveData(this.settings);
205198
}
206199
}
207-
208-
class SampleModal extends Modal {
209-
constructor(app: App) {
210-
super(app);
211-
}
212-
213-
onOpen() {
214-
const {contentEl} = this;
215-
contentEl.setText('Woah!');
216-
}
217-
218-
onClose() {
219-
const {contentEl} = this;
220-
contentEl.empty();
221-
}
222-
}

0 commit comments

Comments
 (0)