Skip to content

Commit 064336a

Browse files
committed
Make TaskQueueEnvKey constant private
Change TaskQueueEnvKey to taskQueueEnvKey since it's not used outside the package. Addresses: temporalio#127 (comment)
1 parent 281a245 commit 064336a

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

internal/testhelpers/make.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import (
1313
)
1414

1515
const (
16-
TaskQueueEnvKey = "TEMPORAL_TASK_QUEUE"
16+
taskQueueEnvKey = "TEMPORAL_TASK_QUEUE"
1717
)
1818

1919
func MakeTWD(
@@ -64,7 +64,7 @@ func MakeTWD(
6464
// MakePodSpec creates a pod spec with the given containers, labels, and task queue
6565
func MakePodSpec(containers []corev1.Container, labels map[string]string, taskQueue string) corev1.PodTemplateSpec {
6666
for i := range containers {
67-
containers[i].Env = append(containers[i].Env, corev1.EnvVar{Name: TaskQueueEnvKey, Value: taskQueue})
67+
containers[i].Env = append(containers[i].Env, corev1.EnvVar{Name: taskQueueEnvKey, Value: taskQueue})
6868
}
6969

7070
return corev1.PodTemplateSpec{
@@ -84,19 +84,19 @@ func MakePodSpecWithImage(imageName string) corev1.PodTemplateSpec {
8484
"")
8585
}
8686

87-
// SetTaskQueue sets or replaces the env var TaskQueueEnvKey with the given string in all containers
87+
// SetTaskQueue sets or replaces the env var taskQueueEnvKey with the given string in all containers
8888
func SetTaskQueue(podSpec corev1.PodTemplateSpec, taskQueue string) corev1.PodTemplateSpec {
8989
for i, c := range podSpec.Spec.Containers {
9090
found := false
9191
for j, e := range c.Env {
92-
if e.Name == TaskQueueEnvKey {
92+
if e.Name == taskQueueEnvKey {
9393
found = true
9494
podSpec.Spec.Containers[i].Env[j].Value = taskQueue
9595
}
9696
}
9797
if !found {
9898
podSpec.Spec.Containers[i].Env = append(podSpec.Spec.Containers[i].Env, corev1.EnvVar{
99-
Name: TaskQueueEnvKey,
99+
Name: taskQueueEnvKey,
100100
Value: taskQueue,
101101
})
102102
}

internal/testhelpers/workers.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ func newVersionedWorker(ctx context.Context, podTemplateSpec corev1.PodTemplateS
3737
if err != nil {
3838
return nil, nil, err
3939
}
40-
temporalTaskQueue, err := getEnv(podTemplateSpec, TaskQueueEnvKey)
40+
temporalTaskQueue, err := getEnv(podTemplateSpec, taskQueueEnvKey)
4141
if err != nil {
4242
return nil, nil, err
4343
}

0 commit comments

Comments
 (0)