Fix 404 on SSO callback handler (aws#4924)

rli · web-flow · commit 21fac7203fe9 · 2024-10-01T15:57:22.000-07:00
Browsers would attempt to request `favicon.ico` which fail all request chains, leading to platform fallback to `BuiltInWebServer`/`DefaultWebServerPathHandler`.

This would be fine, except the platform webserver respects the browser's `Connection: keep-alive` flag and keeps the Netty channel open, and subsequent requests to `.../oauthCallback/...` get handled by `DefaultWebServerPathHandler` and always return 404.
diff --git a/.changes/next-release/bugfix-10275db3-073a-4531-8559-98071108341f.json b/.changes/next-release/bugfix-10275db3-073a-4531-8559-98071108341f.json
@@ -0,0 +1,4 @@
+{
+  "type" : "bugfix",
+  "description" : "Fix issue where multiple SSO login attempts in a short time result in 404"
+}
diff --git a/plugins/core/jetbrains-community/resources/oauthCallback/index.html b/plugins/core/jetbrains-community/resources/oauthCallback/index.html
@@ -8,6 +8,7 @@
     <title>AWS Authentication</title>
     <meta name="viewport" content="width=device-width, initial-scale=1" />
     <link rel="stylesheet" type="text/css" media="screen" href="auth.css" />
+    <link rel="icon" href="data:;base64,iVBORw0KGgo=">
 </head>
 
 <body>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +{
 +  "type" : "bugfix",
 +  "description" : "Fix issue where multiple SSO login attempts in a short time result in 404"
 +}