chore: Update dependencies.

Author: cartant

package.json

@@ -4,23 +4,23 @@
     "url": "https://github.com/cartant/eslint-plugin-rxjs-angular/issues"
   },
   "dependencies": {
-    "@typescript-eslint/experimental-utils": "^4.0.0",
+    "@typescript-eslint/experimental-utils": "^5.0.0",
     "common-tags": "^1.8.0",
-    "eslint-etc": "^4.0.4",
+    "eslint-etc": "^5.0.0",
     "requireindex": "~1.2.0",
     "tslib": "^2.0.0"
   },
   "description": "ESLint rules for RxJS and Angular",
   "devDependencies": {
-    "@cartant/eslint-config": "^2.0.0",
+    "@cartant/eslint-config": "^3.0.0",
     "@types/chai": "^4.2.0",
     "@types/common-tags": "^1.8.0",
     "@types/eslint": "^7.0.0",
     "@types/mocha": "^9.0.0",
     "@types/node": "^16.0.0",
-    "@typescript-eslint/parser": "^4.0.0",
+    "@typescript-eslint/parser": "^5.0.0",
     "chai": "^4.2.0",
-    "eslint": "^7.0.0",
+    "eslint": "^8.0.0",
     "husky": "^7.0.0",
     "lint-staged": "^11.0.0",
     "mocha": "^9.0.0",
@@ -29,9 +29,6 @@
     "ts-node": "^10.0.0",
     "typescript": "~4.4.2"
   },
-  "engines": {
-    "node": ">=12.0.0"
-  },
   "files": [
     "dist",
     "docs"
@@ -52,8 +49,8 @@
   "name": "eslint-plugin-rxjs-angular",
   "optionalDependencies": {},
   "peerDependencies": {
-    "eslint": "^5.0.0 || ^6.0.0 || ^7.0.0",
-    "typescript": "^3.0.0 || ^4.0.0"
+    "eslint": "^8.0.0",
+    "typescript": "^4.0.0"
   },
   "private": false,
   "publishConfig": {

source/rules/prefer-async-pipe.ts

@@ -11,12 +11,12 @@ const rule = ruleCreator({
   defaultOptions: [],
   meta: {
     docs: {
-      category: "Best Practices",
       description:
         "Forbids the calling of `subscribe` within Angular components.",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages: {
       forbidden:
         "Calling `subscribe` in a component is forbidden; use an `async` pipe instead.",

source/rules/prefer-composition.ts

@@ -24,12 +24,12 @@ const rule = ruleCreator({
   defaultOptions,
   meta: {
     docs: {
-      category: "Best Practices",
       description:
         "Forbids `subscribe` calls that are not composed within Angular components (and, optionally, within services, directives, and pipes).",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages: {
       notComposed: "Subscription not composed.",
       notDeclared: "Composed subscription `{{name}}` not a class property.",
@@ -58,7 +58,7 @@ const rule = ruleCreator({
     type Entry = {
       addCallExpressions: es.CallExpression[];
       classDeclaration: es.ClassDeclaration;
-      classProperties: es.ClassProperty[];
+      propertyDefinitions: es.PropertyDefinition[];
       hasDecorator: boolean;
       ngOnDestroyDefinition?: es.MethodDefinition;
       subscribeCallExpressions: es.CallExpression[];
@@ -70,7 +70,7 @@ const rule = ruleCreator({
     function checkEntry(record: Entry) {
       const {
         classDeclaration,
-        classProperties,
+        propertyDefinitions,
         ngOnDestroyDefinition,
         subscribeCallExpressions,
         subscriptions,
@@ -106,10 +106,11 @@ const rule = ruleCreator({
       }
 
       subscriptions.forEach((subscription) => {
-        const classProperty = classProperties.find(
-          (classProperty: any) => classProperty.key.name === subscription
+        const propertyDefinition = propertyDefinitions.find(
+          (propertyDefinition: any) =>
+            propertyDefinition.key.name === subscription
         );
-        if (!classProperty) {
+        if (!propertyDefinition) {
           context.report({
             data: { name: subscription },
             messageId: "notDeclared",
@@ -128,7 +129,7 @@ const rule = ruleCreator({
           context.report({
             data: { name: subscription },
             messageId: "notUnsubscribed",
-            node: classProperty.key,
+            node: propertyDefinition.key,
           });
           return;
         }
@@ -260,7 +261,7 @@ const rule = ruleCreator({
         entries.push({
           addCallExpressions: [],
           classDeclaration: node,
-          classProperties: [],
+          propertyDefinitions: [],
           hasDecorator: hasDecorator(node),
           subscribeCallExpressions: [],
           subscriptions: new Set<string>(),
@@ -273,10 +274,10 @@ const rule = ruleCreator({
           checkEntry(entry);
         }
       },
-      ClassProperty: (node: es.ClassProperty) => {
+      PropertyDefinition: (node: es.PropertyDefinition) => {
         const entry = getEntry();
         if (entry && entry.hasDecorator) {
-          entry.classProperties.push(node);
+          entry.propertyDefinitions.push(node);
         }
       },
       "MethodDefinition[key.name='ngOnDestroy'][kind='method']": (
@@ -287,14 +288,13 @@ const rule = ruleCreator({
           entry.ngOnDestroyDefinition = node;
         }
       },
-      "MethodDefinition[key.name='ngOnDestroy'][kind='method'] CallExpression[callee.property.name='unsubscribe']": (
-        node: es.CallExpression
-      ) => {
-        const entry = getEntry();
-        if (entry && entry.hasDecorator) {
-          entry.unsubscribeCallExpressions.push(node);
-        }
-      },
+      "MethodDefinition[key.name='ngOnDestroy'][kind='method'] CallExpression[callee.property.name='unsubscribe']":
+        (node: es.CallExpression) => {
+          const entry = getEntry();
+          if (entry && entry.hasDecorator) {
+            entry.unsubscribeCallExpressions.push(node);
+          }
+        },
     };
   },
 });

source/rules/prefer-takeuntil.ts

@@ -37,12 +37,12 @@ const rule = ruleCreator({
   defaultOptions,
   meta: {
     docs: {
-      category: "Best Practices",
       description:
         "Forbids `subscribe` calls without an accompanying `takeUntil` within Angular components (and, optionally, within services, directives, and pipes).",
       recommended: false,
     },
     fixable: undefined,
+    hasSuggestions: false,
     messages,
     schema: [
       {
@@ -82,7 +82,7 @@ const rule = ruleCreator({
 
     type Entry = {
       classDeclaration: es.ClassDeclaration;
-      classProperties: es.Node[];
+      propertyDefinitions: es.PropertyDefinition[];
       completeCallExpressions: es.CallExpression[];
       hasDecorator: boolean;
       nextCallExpressions: es.CallExpression[];
@@ -240,11 +240,11 @@ const rule = ruleCreator({
     }
 
     function checkSubjectProperty(name: string, entry: Entry) {
-      const { classProperties } = entry;
-      const classProperty = classProperties.find(
-        (classProperty: any) => classProperty.key.name === name
+      const { propertyDefinitions } = entry;
+      const propertyDefinition = propertyDefinitions.find(
+        (propertyDefinition: any) => propertyDefinition.key.name === name
       );
-      return Boolean(classProperty);
+      return Boolean(propertyDefinition);
     }
 
     function checkSubscribe(callExpression: es.CallExpression, entry: Entry) {
@@ -321,7 +321,7 @@ const rule = ruleCreator({
       ClassDeclaration: (node: es.ClassDeclaration) => {
         entries.push({
           classDeclaration: node,
-          classProperties: [],
+          propertyDefinitions: [],
           completeCallExpressions: [],
           nextCallExpressions: [],
           hasDecorator: hasDecorator(node),
@@ -338,10 +338,10 @@ const rule = ruleCreator({
           checkEntry(entry);
         }
       },
-      ClassProperty: (node: es.Node) => {
+      PropertyDefinition: (node: es.PropertyDefinition) => {
         const entry = getEntry();
         if (entry && entry.hasDecorator) {
-          entry.classProperties.push(node);
+          entry.propertyDefinitions.push(node);
         }
       },
       "MethodDefinition[key.name='ngOnDestroy'][kind='method']": (
@@ -352,22 +352,20 @@ const rule = ruleCreator({
           entry.ngOnDestroyDefinition = node;
         }
       },
-      "MethodDefinition[key.name='ngOnDestroy'][kind='method'] CallExpression[callee.property.name='next']": (
-        node: es.CallExpression
-      ) => {
-        const entry = getEntry();
-        if (entry && entry.hasDecorator) {
-          entry.nextCallExpressions.push(node);
-        }
-      },
-      "MethodDefinition[key.name='ngOnDestroy'][kind='method'] CallExpression[callee.property.name='complete']": (
-        node: es.CallExpression
-      ) => {
-        const entry = getEntry();
-        if (entry && entry.hasDecorator) {
-          entry.completeCallExpressions.push(node);
-        }
-      },
+      "MethodDefinition[key.name='ngOnDestroy'][kind='method'] CallExpression[callee.property.name='next']":
+        (node: es.CallExpression) => {
+          const entry = getEntry();
+          if (entry && entry.hasDecorator) {
+            entry.nextCallExpressions.push(node);
+          }
+        },
+      "MethodDefinition[key.name='ngOnDestroy'][kind='method'] CallExpression[callee.property.name='complete']":
+        (node: es.CallExpression) => {
+          const entry = getEntry();
+          if (entry && entry.hasDecorator) {
+            entry.completeCallExpressions.push(node);
+          }
+        },
     };
   },
 });