Skip to content

rxjs/finnish doesn't detect implicitly typed Observable functions #141

@leroydev

Description

@leroydev

The rxjs/finnish rule flags me to end FunctionExplicitlyReturningObservable with a $ but doesn't do the same for FunctionImplicitlyReturningObservable. It seems like this is because the rule doesn't detect functions implicitly having an Observable return type?

import { Observable, of } from 'rxjs';

function FunctionImplicitlyReturningObservable() {
  return of([]);
}

function FunctionExplicitlyReturningObservable(): Observable<[]> {
  return of([]);
}
Image

If this is seen as a problem I could try to make a PR to fix this.

Thanks in advance!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions