Skip to content

Conversation

skrtheboss
Copy link

Fixes #100

JasonWeinzierl added a commit to JasonWeinzierl/eslint-plugin-rxjs-x that referenced this pull request Nov 8, 2024
Fixes cartant#100

There's also a proposed fix PR in the upstream repo
cartant#114 but I avoided
looking at that solution to avoid any license issue, so this solution
might be different.

- Fix: if the `shareReplay` operator was passed an object config, then
require `bufferSize` to be in that object.
- Fix: the rule wasn't handling if `shareReplay` is imported under a
namespace.
- (Might need to review the entire project. Since rxjs now recommends
importing from "rxjs" instead of "rxjs/operators", there's a risk that
many rules also fail to account for that new paradigm. Note that this
rule is the only rule that tests namespace imports for all cases, so we
at least should expand that coverage/type of test.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-ignored-replay-buffer doesn't check bufferSize if object config passed to shareReplay
1 participant