Add limited constant retry strategy. #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelGrupp
commented
Sep 17, 2018
| @@ -48,7 +57,7 @@ RetryIndicator CreateUnlimitedRetryIndicator( | |||
| const std::set<::grpc::StatusCode> &unrecoverable_codes) { | |||
| return | |||
| [unrecoverable_codes](int failed_attempts, const ::grpc::Status &status) { | |||
| return unrecoverable_codes.count(status.error_code()) <= 0; | |||
| return !unrecoverable_codes.count(status.error_code()); | |||
There was a problem hiding this comment.
Changed this because it didn't make sense, count() returns either 1 or 0 for a set.
We can change it to count == 0 if you prefer that style.
cschuet
approved these changes
Sep 17, 2018
|
@cschuet This is open since a while, should we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.