Sync Claude workflows from workspace (#1774)

tarrencev · web-flow · commit 4874b36af93b · 2025-06-19T11:53:34.000-04:00
## Summary This PR synchronizes the Claude Code workflows from the workspace repository templates with repository-specific customizations for the TypeScript/React gaming wallet codebase. ### Changes Made - **Updated `.github/workflows/claude-code-review.yml`**: - Applied latest template structure with updated review flow - Enhanced with TypeScript/React specific review focus areas - Added redundancy checks for existing reviews/comments - Configured for gaming wallet and blockchain integration patterns - **Updated `.github/workflows/claude.yml`**: - Applied latest template structure with ast-grep support - Preserved repository-specific pnpm and monorepo development commands - Updated custom instructions for TypeScript/React best practices - Added Node.js setup for ast-grep integration ### Key Features - **Review Workflow**: Focuses on TypeScript/React quality, wallet/blockchain integration, UI/UX, testing, monorepo, and security - **Interactive Workflow**: Supports pnpm commands, Turbo build system, and monorepo structure - **Template Synchronization**: Maintains consistency with workspace standards while preserving repository-specific needs ### Test Plan - [ ] Verify workflows trigger correctly on PR creation - [ ] Test Claude Code review functionality with sample PR - [ ] Confirm pnpm and monorepo commands work as expected 🤖 Generated via workspace coordination from [cartridge-gg/workspace#27](cartridge-gg/workspace#27)
diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml
@@ -1,26 +1,44 @@
-name: claude-code-review
+name: claude
 
 on:
   pull_request:
     types: [opened, synchronize]
 
 jobs:
   claude-review:
+    # Optional: Filter by PR author
+    # if: |
+    #   github.event.pull_request.user.login == 'external-contributor' ||
+    #   github.event.pull_request.user.login == 'new-developer' ||
+    #   github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR'
+
     runs-on: ubuntu-latest
     permissions:
       contents: read
-      pull-requests: read
+      pull-requests: write
       issues: read
       id-token: write
 
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
         with:
-          fetch-depth: 1
+          fetch-depth: 2
+
+      - name: Check if commit is from Claude
+        id: check-author
+        run: |
+          AUTHOR_EMAIL=$(git log -1 --pretty=format:'%ae')
+          AUTHOR_NAME=$(git log -1 --pretty=format:'%an')
+          if [[ "$AUTHOR_EMAIL" == *"claude[bot]"* ]] || [[ "$AUTHOR_NAME" == *"claude[bot]"* ]]; then
+            echo "skip=true" >> $GITHUB_OUTPUT
+          else
+            echo "skip=false" >> $GITHUB_OUTPUT
+          fi
 
       - name: Run Claude Code Review
         id: claude-review
+        if: steps.check-author.outputs.skip != 'true'
         uses: anthropics/claude-code-action@beta
         with:
           anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
@@ -30,33 +48,72 @@ jobs:
 
           # Direct prompt for automated review (no @claude mention needed)
           direct_prompt: |
-            Please review this pull request and provide feedback on:
-            - Code quality and best practices
-            - Potential bugs or issues
-            - Performance considerations
-            - Security concerns
-            - Test coverage
-
-            Be constructive and helpful in your feedback.
-
-          # Optional: Customize review based on file types
-          # direct_prompt: |
-          #   Review this PR focusing on:
-          #   - For TypeScript files: Type safety and proper interface usage
-          #   - For API endpoints: Security, input validation, and error handling
-          #   - For React components: Performance, accessibility, and best practices
-          #   - For tests: Coverage, edge cases, and test quality
-
-          # Optional: Different prompts for different authors
-          # direct_prompt: |
-          #   ${{ github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR' &&
-          #   'Welcome! Please review this PR from a first-time contributor. Be encouraging and provide detailed explanations for any suggestions.' ||
-          #   'Please provide a thorough code review focusing on our coding standards and best practices.' }}
-
-          # Optional: Add specific tools for running tests or linting
-          # allowed_tools: "Bash(npm run test),Bash(npm run lint),Bash(npm run typecheck)"
-
-          # Optional: Skip review for certain conditions
-          # if: |
-          #   !contains(github.event.pull_request.title, '[skip-review]') &&
-          #   !contains(github.event.pull_request.title, '[WIP]')
+            Please review this TypeScript/React gaming wallet PR and provide inline feedback using the GitHub review system. Follow these steps:
+
+            1. **Check for existing reviews**: First, use `mcp__github__get_pull_request_reviews` to check if you have any existing pending or submitted reviews on this PR
+            2. **Check existing comments**: Use `mcp__github__get_pull_request_comments` to see what comments have already been made to avoid redundancy
+            3. **Start a fresh review**: Use `mcp__github__create_pending_pull_request_review` to begin a new pending review
+            4. **Get diff information**: Use `mcp__github__get_pull_request_diff` to understand the code changes
+            5. **Add unique inline comments**: Only add comments for issues that haven't been addressed in existing reviews
+            6. **Add inline comments**: Use `mcp__github__add_pull_request_review_comment_to_pending_review` for each specific piece of feedback on particular lines, including code change suggestions where appropriate using multiline comments and the suggestion syntax:
+
+            ```suggestion
+              const ExampleComponent: React.FC<Props> = ({ children }) => {
+                return <div>{children}</div>;
+              };
+            ```
+
+            7. **Submit the review**: Use `mcp__github__submit_pending_pull_request_review` with event type "COMMENT" (not "REQUEST_CHANGES") to publish all comments as a non-blocking review
+
+            Only comment when something is off, wrong, or could be improved but don't be overly pedantic; if a given implementation is already good, do not comment on it.
+
+            Focus your review on:
+
+            **TypeScript/React Code Quality:**
+            - Type safety and proper TypeScript usage
+            - React hooks usage and lifecycle management
+            - Component composition and reusability
+            - Props interface design and validation
+            - State management patterns
+            
+            **Wallet & Blockchain Integration:**
+            - StarkNet integration best practices
+            - Account abstraction implementation
+            - Session token management
+            - WebAuthn/Passkeys security patterns
+            - Iframe communication security
+            
+            **UI/UX & Accessibility:**
+            - Component API consistency
+            - Storybook story completeness
+            - TailwindCSS usage patterns
+            - Responsive design considerations
+            - Accessibility best practices
+            
+            **Testing & Quality:**
+            - Jest unit test coverage and quality
+            - Storybook visual regression tests
+            - Playwright E2E test completeness
+            - Mock usage and test isolation
+            - Error boundary implementation
+            
+            **Monorepo & Build:**
+            - Package interdependencies
+            - Turbo build configuration
+            - Workspace protocol usage
+            - Bundle size considerations
+            - Performance optimizations
+            
+            **Security:**
+            - Input validation and sanitization
+            - XSS prevention
+            - Secure iframe communication
+            - Sensitive data handling
+            - Authentication flow security
+
+            Provide specific, actionable feedback with inline comments and suggestions for line-specific issues. Include an concise overall summary when submitting the review.
+
+            **Important**: Submit as "COMMENT" type so the review doesn't block the PR.
+
+          # Add MCP GitHub tools for inline comments and project-specific testing
+          allowed_tools: "mcp__github__create_pending_pull_request_review,mcp__github__get_pull_request_comments,mcp__github__get_pull_request_reviews,mcp__github__add_pull_request_review_comment_to_pending_review,mcp__github__submit_pending_pull_request_review,mcp__github__get_pull_request_diff,Bash(pnpm install),Bash(pnpm run build),Bash(pnpm run test:*),Bash(pnpm run lint:*),Bash(pnpm run format),Bash(pnpm run dev),Bash(pnpm run storybook),Bash(pnpm run e2e:*),Bash(pnpm --filter *),Bash(pnpm run clean),Bash(corepack enable pnpm)"
diff --git a/.github/workflows/claude.yml b/.github/workflows/claude.yml
@@ -1,4 +1,4 @@
-name: claude
+name: Claude Code
 
 on:
   issue_comment:
@@ -19,15 +19,26 @@ jobs:
       (github.event_name == 'issues' && (contains(github.event.issue.body, '@claude') || contains(github.event.issue.title, '@claude')))
     runs-on: ubuntu-latest
     permissions:
-      contents: read
-      pull-requests: read
-      issues: read
+      contents: write
+      pull-requests: write
+      issues: write
       id-token: write
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
         with:
           fetch-depth: 1
+          token: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+
+      - name: Install ast-grep
+        run: |
+          npm install -g @ast-grep/cli
+          ast-grep --version
 
       - name: Run Claude Code
         id: claude
@@ -44,64 +55,16 @@ jobs:
           # Optional: Trigger when specific user is assigned to an issue
           assignee_trigger: "claude-bot"
 
-          # Add MCP GitHub tools for inline comments and TypeScript/React testing
-          allowed_tools: "mcp__github__create_pending_pull_request_review,mcp__github__add_pull_request_review_comment_to_pending_review,mcp__github__submit_pending_pull_request_review,mcp__github__get_pull_request_diff,Bash(pnpm install),Bash(pnpm run build),Bash(pnpm run test:*),Bash(pnpm run lint:*),Bash(pnpm run format),Bash(pnpm run dev),Bash(pnpm run storybook),Bash(pnpm run e2e:*),Bash(pnpm --filter *),Bash(pnpm run clean),Bash(corepack enable pnpm)"
-
-          # Custom instructions for Claude to provide comprehensive TypeScript/React reviews
-          direct_prompt: |
-            Please review this TypeScript/React gaming wallet PR and provide inline feedback using the GitHub review system. Follow these steps:
-
-            1. **Start a review**: Use `mcp__github__create_pending_pull_request_review` to begin a pending review
-            2. **Get diff information**: Use `mcp__github__get_pull_request_diff` to understand the code changes and line numbers
-            3. **Add inline comments**: Use `mcp__github__add_pull_request_review_comment_to_pending_review` for each specific piece of feedback on particular lines, including code change suggestions where appropriate
-            4. **Submit the review**: Use `mcp__github__submit_pending_pull_request_review` with event type "COMMENT" (not "REQUEST_CHANGES") to publish all comments as a non-blocking review
+          # Customize allowed tools and commands for your repository
+          allowed_tools: "mcp__github__create_pull_request,Bash,Glob,Grep,LS,Read,Edit,MultiEdit,Write"
 
-            Focus your review on:
-            
-            **TypeScript/React Code Quality:**
-            - Type safety and proper TypeScript usage
-            - React hooks usage and lifecycle management
-            - Component composition and reusability
-            - Props interface design and validation
-            - State management patterns
-            
-            **Wallet & Blockchain Integration:**
-            - StarkNet integration best practices
-            - Account abstraction implementation
-            - Session token management
-            - WebAuthn/Passkeys security patterns
-            - Iframe communication security
-            
-            **UI/UX & Accessibility:**
-            - Component API consistency
-            - Storybook story completeness
-            - TailwindCSS usage patterns
-            - Responsive design considerations
-            - Accessibility best practices
-            
-            **Testing & Quality:**
-            - Jest unit test coverage and quality
-            - Storybook visual regression tests
-            - Playwright E2E test completeness
-            - Mock usage and test isolation
-            - Error boundary implementation
-            
-            **Monorepo & Build:**
-            - Package interdependencies
-            - Turbo build configuration
-            - Workspace protocol usage
-            - Bundle size considerations
-            - Performance optimizations
-            
-            **Security:**
-            - Input validation and sanitization
-            - XSS prevention
-            - Secure iframe communication
-            - Sensitive data handling
-            - Authentication flow security
+          # Add custom instructions specific to your codebase
+          custom_instructions: |
+            Always review the instructions in the CLAUDE.md file before proceeding.
 
-            Provide specific, actionable feedback with inline comments for line-specific issues and include an overall summary when submitting the review. **Important**: Submit as "COMMENT" type so the review doesn't block the PR.
+            IMPORTANT: When you make changes to files, you must create a Pull Request:
+            1. Use mcp__github__create_pull_request to create a PR
+            2. If responding to an issue, include "Closes #[ISSUE_NUMBER]" in the PR description
+            3. Provide a clear title and description explaining what was changed and why
 
-          # Optional: Custom environment variables for Claude
-          # claude_env: |
-          #   NODE_ENV: test
+            Never commit directly to main branch. Always create PRs for changes.
