-
Notifications
You must be signed in to change notification settings - Fork 140
Open
Labels
enhancementThis issue is a feature requestThis issue is a feature requestgood first issueAn issue that will be a good candidate for a new contributorAn issue that will be a good candidate for a new contributorpriority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Description
The current install script has bogus requirements of bash and shasum. Because of the way it is written the script runs fine with sh and sha1sum.
This should be fixed because some environments, for example the Alpine Linux docker image, do not have them.
If you are checking for curl and wget, you should also check for sha1sum (or better yet use sha256sum).
The hard requirement on bash is just unneeded.
The requirements can easily be bypassed by just faking the environment, proving my point:
cat <(echo "BASH_VERSION=fake; function shasum() { sha1sum $@; }") <(wget -O- https://carvel.dev/install.sh) | shReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementThis issue is a feature requestThis issue is a feature requestgood first issueAn issue that will be a good candidate for a new contributorAn issue that will be a good candidate for a new contributorpriority/important-longtermImportant over the long term, but may not be staffed and/or may need multiple releases to complete.Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Type
Projects
Status
Prioritized Backlog