Merge pull request #389 from benmoss/fix-verify-checksums

joaopapereira · web-flow · commit 2fcf08d9a6d6 · 2022-05-11T14:55:20.000-05:00
Don't dirty the working directory with release checksums
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -87,9 +87,9 @@ jobs:
           set -e -x
           VERSION=`echo ${{ github.ref }}  | grep -Eo '[0-9].*'`
 
-          ./hack/build-binaries.sh "$VERSION" > ./go-checksums
-          cat ./go-checksums
-          diff ./go-checksums <(cat <<EOF
+          ./hack/build-binaries.sh "$VERSION" > /tmp/go-checksums
+          cat /tmp/go-checksums
+          diff /tmp/go-checksums <(cat <<EOF
           ${{steps.get-checksums-from-draft-release.outputs.result}}
           EOF
           )
diff --git a/hack/build.sh b/hack/build.sh
@@ -21,7 +21,7 @@ git diff --exit-code vendor/github.com/vdemeester || {
 }
 
 # export GOOS=linux GOARCH=amd64
-go build -ldflags="$LDFLAGS" -trimpath -o "imgpkg${IMGPKG_BINARY_EXT-}" ./cmd/imgpkg/...
+go build -trimpath -o "imgpkg${IMGPKG_BINARY_EXT-}" ./cmd/imgpkg/...
 ./imgpkg version
 
 # compile tests, but do not run them: https://github.com/golang/go/issues/15513#issuecomment-839126426

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ git diff --exit-code vendor/github.com/vdemeester \|\| {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`# export GOOS=linux GOARCH=amd64`
`24`		`-go build -ldflags="$LDFLAGS" -trimpath -o "imgpkg${IMGPKG_BINARY_EXT-}" ./cmd/imgpkg/...`
	`24`	`+go build -trimpath -o "imgpkg${IMGPKG_BINARY_EXT-}" ./cmd/imgpkg/...`
`25`	`25`	`./imgpkg version`
`26`	`26`
`27`	`27`	`# compile tests, but do not run them: https://github.com/golang/go/issues/15513#issuecomment-839126426`