fix: buildIncrementalRoleLinks and if condition negate.

Signed-off-by: DivyPatel9881 <[email protected]>

Author: divy9881

casbin/model/assertion.cpp

@@ -30,8 +30,8 @@ void Assertion :: BuildIncrementalRoleLinks(RoleManager* rm, policy_op op, vecto
     if (char_count < 2)
         throw IllegalArgumentException("the number of \"_\" in role definition should be at least 2");
 
-    for(int i = 0 ; i < this->policy.size() ; i++){
-        vector<string> rule = this->policy[i];
+    for(int i = 0 ; i < rules.size() ; i++){
+        vector<string> rule = rules[i];
 
         if (rule.size() < char_count)
             throw IllegalArgumentException("grouping policy elements do not meet role definition");
@@ -43,6 +43,7 @@ void Assertion :: BuildIncrementalRoleLinks(RoleManager* rm, policy_op op, vecto
         switch(op) {
             case policy_op :: policy_add:
                 this->rm->AddLink(rule[0], rule[1], domain);
+                break;
             case policy_op :: policy_remove:
                 this->rm->DeleteLink(rule[0], rule[1], domain);
         }

casbin/rbac/default_role_manager.cpp

@@ -254,7 +254,7 @@ vector<string> DefaultRoleManager :: GetUsers(string name, vector<string> domain
     else if (domain.size() > 1)
         throw CasbinRBACException("error: domain should be 1 parameter");
 
-    if (this->HasRole(name))
+    if (!this->HasRole(name))
         throw CasbinRBACException("error: name does not exist");
 
     vector<string> names;