fix: test

Signed-off-by: Yash Pandey (YP) <[email protected]>

Author: EmperorYP7

casbin/util/array_remove_duplicates.cpp

@@ -28,7 +28,7 @@ namespace casbin {
 
 // ArrayRemoveDuplicates removes any duplicated elements in a std::string array.
 void ArrayRemoveDuplicates(std::vector<std::string> &s) {
-    std::unordered_map<std::string_view, bool> found;
+    std::unordered_map<std::string, bool> found;
     found.reserve(s.size());
     int j = 0;
     for (const std::string& it : s) {
@@ -37,7 +37,7 @@ void ArrayRemoveDuplicates(std::vector<std::string> &s) {
             s[j++] = it;
         }
     }
-    s.erase(s.begin() + j + 1, s.end());
+    s.erase(s.begin() + j, s.end());
 }
 
 } // namespace casbin

casbin/util/set_subtract.cpp

@@ -28,7 +28,7 @@ namespace casbin {
 
 // SetSubtract returns the elements in `a` that aren't in `b`.
 std::vector<std::string> SetSubtract(const std::vector<std::string>& a, const std::vector<std::string>& b) {
-    std::unordered_map<std::string_view, bool> mb;
+    std::unordered_map<std::string, bool> mb;
     mb.reserve(b.size());
 
     for (const std::string& it : b)

tests/management_api_test.cpp

@@ -26,11 +26,10 @@ TEST(TestManagementAPI, TestGetList) {
     std::string policy = "../../examples/rbac_policy.csv";
     casbin::Enforcer e(model, policy);
 
-    // ASSERT_TRUE(casbin::ArrayEquals({ "alice", "bob", "data2_admin" }, e.GetAllSubjects()));
-    // ASSERT_TRUE(casbin::ArrayEquals({"alice", "bob"}, e.GetAllSubjects()));
-    // ASSERT_TRUE(casbin::ArrayEquals({ "data1", "data2" }, e.GetAllObjects()));
-    // ASSERT_TRUE(casbin::ArrayEquals({ "read", "write" }, e.GetAllActions()));
-    // ASSERT_TRUE(casbin::ArrayEquals({ "data2_admin" }, e.GetAllRoles()));
+    ASSERT_TRUE(casbin::ArrayEquals({ "alice", "bob", "data2_admin" }, e.GetAllSubjects()));
+    ASSERT_TRUE(casbin::ArrayEquals({ "data1", "data2" }, e.GetAllObjects()));
+    ASSERT_TRUE(casbin::ArrayEquals({ "read", "write" }, e.GetAllActions()));
+    ASSERT_TRUE(casbin::ArrayEquals({ "data2_admin" }, e.GetAllRoles()));
 }
 
 void TestGetPolicy(casbin::Enforcer& e, const std::vector<std::vector<std::string>>& res) {
@@ -278,7 +277,7 @@ TEST(TestManagementAPI, TestModifyGroupingPolicyAPI) {
     e.UpdateGroupingPolicy({"eve", "data3_admin"}, {"eve", "admin"});
     e.UpdateGroupingPolicy({"data3_admin", "data4_admin"}, {"admin", "data4_admin"});
 
-    // ASSERT_TRUE(ArrayEquals({"admin"}, e.GetUsersForRole("data4_admin")));
+    // ASSERT_TRUE(casbin::ArrayEquals({"admin"}, e.GetUsersForRole("data4_admin")));
     ASSERT_TRUE(casbin::ArrayEquals({"eve"}, e.GetUsersForRole("admin")));
 
     ASSERT_TRUE(casbin::ArrayEquals({"admin"}, e.GetRolesForUser("eve")));

tests/rbac_api_test.cpp

@@ -213,16 +213,16 @@ TEST(TestRBACAPI, TestImplicitPermissionAPIWithDomain) {
 TEST(TestRBACAPI, TestImplicitUserAPI) {
     casbin::Enforcer e("../../examples/rbac_model.conf", "../../examples/rbac_with_hierarchy_policy.csv");
 
-    // ASSERT_TRUE(casbin::ArrayEquals({ "alice" }, e.GetImplicitUsersForPermission({ "data1", "read" })));
-    // ASSERT_TRUE(casbin::ArrayEquals({ "alice" }, e.GetImplicitUsersForPermission({ "data1", "write" })));
-    // ASSERT_TRUE(casbin::ArrayEquals({ "alice" }, e.GetImplicitUsersForPermission({ "data2", "read" })));
-    // ASSERT_TRUE(casbin::ArrayEquals({ "alice", "bob" }, e.GetImplicitUsersForPermission({ "data2", "write" })));
+    ASSERT_TRUE(casbin::ArrayEquals({ "alice" }, e.GetImplicitUsersForPermission({ "data1", "read" })));
+    ASSERT_TRUE(casbin::ArrayEquals({ "alice" }, e.GetImplicitUsersForPermission({ "data1", "write" })));
+    ASSERT_TRUE(casbin::ArrayEquals({ "alice" }, e.GetImplicitUsersForPermission({ "data2", "read" })));
+    ASSERT_TRUE(casbin::ArrayEquals({ "alice", "bob" }, e.GetImplicitUsersForPermission({ "data2", "write" })));
 
     e.ClearPolicy();
     e.AddPolicy({ "admin", "data1", "read" });
     e.AddPolicy({ "bob", "data1", "read" });
     e.AddGroupingPolicy({ "alice", "admin" });
-    // ASSERT_TRUE(casbin::ArrayEquals({ "alice", "bob" }, e.GetImplicitUsersForPermission({ "data1", "read" })));
+    ASSERT_TRUE(casbin::ArrayEquals({ "alice", "bob" }, e.GetImplicitUsersForPermission({ "data1", "read" })));
 }
 
 } // namespace