Skip to content

Commit dd68138

Browse files
committed
fix: Adjusted holder type for model binding
Signed-off-by: Yash Pandey (YP) <[email protected]>
1 parent 5afd18f commit dd68138

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

bindings/python/py_config.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
namespace py = pybind11;
2222

2323
void bindPyConfig(py::module &m) {
24-
py::class_<casbin::Config>(m, "Config")
24+
py::class_<casbin::Config, std::shared_ptr<casbin::Config>>(m, "Config")
2525
.def(py::init<>())
2626
.def(py::init<const std::string&>())
2727
.def_static("NewConfig", &casbin::Config::NewConfig, R"doc(

casbin/config/config.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ class Config : public ConfigInterface {
6464

6565
bool GetBool(std::string_view key);
6666

67+
Config();
68+
6769
Config(const std::string& conf_name);
6870

6971
int GetInt(std::string_view key);

tests/python/test_model.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ def test_NewModelFromString(self):
4545
self.assertIsNotNone(model)
4646

4747
def test_LoadModelFromConfig(self):
48-
# config = casbin.Config(basic_model_path)
49-
# model = casbin.Model.NewModel()
50-
# casbin.LoadModelFromConfig(model, basic_config)
48+
basic_config = casbin.Config.NewConfig(basic_model_path)
49+
model = casbin.Model.NewModel()
50+
model.LoadModelFromConfig(basic_config)
5151
# model = casbin.Model.NewModel()
5252
# config = casbin.Config.NewConfigFromText("")
5353
# model.LoadModelFromConfig(config)

0 commit comments

Comments
 (0)