feat: fix build warnings for all targets (#236)

fix: CMake import issues

fix: virtual destructor warning

chore: removed auto generated files

Author: EmperorYP7

.gitignore

@@ -361,6 +361,7 @@ MigrationBackup/
 cmake-build/
 xcode-build/
 cmake-build*/
+build_support/
 
 # pip
 *.egg-info

CMakeLists.txt

@@ -32,7 +32,7 @@ endif()
 
 project(
     casbin
-    VERSION 1.44.0
+    VERSION 1.53.2
     DESCRIPTION "An authorization library that supports access control models like ACL, RBAC, ABAC in C/C++"
     HOMEPAGE_URL https://github.com/casbin/casbin-cpp
     LANGUAGES CXX C

build_support/clang_format_exclusions.txt

@@ -77,9 +77,8 @@ void Config::ParseBuffer(std::istream* buf) {
         else {
             std::vector<std::string> option_val = Split(line, "=", 2);
             if (option_val.size() != 2) {
-                char* error = new char;
-                sprintf(error, "parse the content error : line %d , %s = ? ", line_num, option_val[0].c_str());
-                throw IllegalArgumentException(std::string(error));
+                std::string error = "parse the content error : line " + std::to_string(line_num)  + " , " + option_val[0] + " = ?";
+                throw IllegalArgumentException(error);
             }
             std::string option = Trim(option_val[0]);
             std::string value = Trim(option_val[1]);

build_support/run_clang_format.py

@@ -108,14 +108,14 @@ CachedEnforcer::CachedEnforcer(const CachedEnforcer& ce)
     this->enableCache = ce.enableCache;
 }
 
-CachedEnforcer::CachedEnforcer(CachedEnforcer&& ce)
+CachedEnforcer::CachedEnforcer(CachedEnforcer&& ce) noexcept
     : Enforcer(ce) {
-    this->m = move(ce.m);
+    this->m = std::move(ce.m);
     this->enableCache = ce.enableCache;
 }
 
-void CachedEnforcer::EnableCache(const bool& enableCache) {
-    this->enableCache = enableCache;
+void CachedEnforcer::EnableCache(const bool& shouldEnableCache) {
+    this->enableCache = shouldEnableCache;
 }
 
 std::pair<bool, bool> CachedEnforcer::getCachedResult(const std::string& key) {

casbin/config/config.cpp

@@ -139,7 +139,7 @@ void SyncedEnforcer ::SetWatcher(std::shared_ptr<Watcher> w) {
 
 // LoadModel reloads the model from the model CONF file.
 void SyncedEnforcer ::LoadModel() {
-    std::unique_lock<std::shared_mutex>(policyMutex);
+    std::unique_lock<std::shared_mutex> lock(policyMutex);
     Enforcer::LoadModel();
 }
 

casbin/enforcer_cached.cpp

@@ -144,10 +144,7 @@ bool Enforcer ::AddNamedPolicy(const std::string& p_type, const std::vector<std:
         return this->addPolicy("p", p_type, str_slice);
     }
 
-    std::vector<std::string> policy;
-    for (int i = 0; i < params.size(); i++)
-        policy.push_back(params[i]);
-    return this->addPolicy("p", p_type, policy);
+    return this->addPolicy("p", p_type, params);
 }
 
 // AddNamedPolicies adds authorization rules to the current named policy.

casbin/enforcer_synced.cpp

@@ -25,8 +25,8 @@
 namespace casbin {
 
 // LoadPolicyLine loads a text line as a policy rule to model.
-void LoadPolicyLine(std::string line, const std::shared_ptr<Model>& model) {
-    if (line == "" || line.find("#") == 0)
+void LoadPolicyLine(const std::string& line, const std::shared_ptr<Model>& model) {
+    if (line.empty() || line.find('#') == 0)
         return;
 
     std::vector<std::string> tokens = Split(line, ",", -1);

casbin/management_api.cpp

@@ -25,7 +25,7 @@
 namespace casbin {
 
 // LoadPolicyLine loads a text line as a policy rule to model.
-void LoadPolicyLine(std::string line, const std::shared_ptr<Model>& model);
+void LoadPolicyLine(const std::string& line, const std::shared_ptr<Model>& model);
 
 /**
  * Adapter is the interface for Casbin adapters.
@@ -34,6 +34,8 @@ class Adapter {
 public:
     bool filtered;
 
+    virtual ~Adapter() = default;
+
     /**
      * LoadPolicy loads all policy rules from the storage.
      *