Fix clippy lints (#549)

Author: casey

Cargo.toml

@@ -70,6 +70,16 @@ features = ["serde"]
 criterion = "0.5.1"
 temptree = "0.2.0"
 
+[lints.clippy]
+all = { level = "deny", priority = -1 }
+float_cmp = "allow"
+large_enum_variant = "allow"
+needless_pass_by_value = "allow"
+pedantic = { level = "deny", priority = -1 }
+struct_excessive_bools = "allow"
+too_many_lines = "allow"
+wildcard_imports = "allow"
+
 [workspace]
 members = [
   # generate documentation

build.rs

@@ -1,5 +1,5 @@
 use std::{
-  io::{self, Error, ErrorKind},
+  io::{self, Error},
   process::Command,
 };
 
@@ -13,7 +13,7 @@ fn is_inside_git_work_tree() -> bool {
 }
 
 fn error(message: String) -> io::Error {
-  Error::new(ErrorKind::Other, message)
+  Error::other(message)
 }
 
 fn commit_hash() -> io::Result<String> {
@@ -33,8 +33,7 @@ fn commit_hash() -> io::Result<String> {
 
   if !hash.chars().all(|c| "0123456789abcdef".contains(c)) {
     return Err(error(format!(
-      "Invalid hash from `git rev-parse HEAD`: {}",
-      hash
+      "Invalid hash from `git rev-parse HEAD`: {hash}",
     )));
   }
 
@@ -47,7 +46,7 @@ fn main() -> io::Result<()> {
     println!("cargo:rustc-env=GIT_HEAD_PARTIAL_HASH= ({})", &hash[0..12]);
   } else {
     println!("cargo:rustc-env=GIT_HEAD_PARTIAL_HASH=");
-  };
+  }
 
   Ok(())
 }

src/file_error.rs

@@ -89,8 +89,7 @@ impl Print for FileError {
       Self::Surfeit(difference) => write!(stream, "{difference} too long")?,
       Self::Dearth(difference) => write!(stream, "{difference} too short")?,
       Self::Md5 { .. } => {
-        return Err(io::Error::new(
-          io::ErrorKind::Other,
+        return Err(io::Error::other(
           Error::internal("Reached unreachable branch").to_string(),
         ))
       }

src/input_target.rs

@@ -20,7 +20,7 @@ impl TryFrom<&OsStr> for InputTarget {
   fn try_from(text: &OsStr) -> Result<Self, Self::Error> {
     if text.is_empty() {
       return Err(Error::InputTargetEmpty);
-    };
+    }
 
     if text == OsStr::new("-") {
       Ok(Self::Stdin)

src/lib.rs

@@ -1,17 +1,3 @@
-#![deny(clippy::all, clippy::pedantic)]
-#![allow(
-  clippy::float_cmp,
-  clippy::needless_lifetimes,
-  clippy::needless_pass_by_value,
-  clippy::non_ascii_literal,
-  clippy::struct_excessive_bools,
-  clippy::too_many_lines,
-  clippy::unseparated_literal_suffix,
-  clippy::wildcard_imports,
-  clippy::large_enum_variant,
-  clippy::module_name_repetitions
-)]
-
 pub use run::run;
 
 #[cfg(test)]

src/metainfo.rs

@@ -99,7 +99,7 @@ impl Metainfo {
     self.info.content_size()
   }
 
-  pub(crate) fn trackers<'a>(&'a self) -> impl Iterator<Item = Result<Url>> + 'a {
+  pub(crate) fn trackers(&self) -> impl Iterator<Item = Result<Url>> + '_ {
     let mut seen = HashSet::new();
     iter::once(&self.announce)
       .flatten()

src/output_target.rs

@@ -27,7 +27,7 @@ impl TryFrom<&OsStr> for OutputTarget {
   fn try_from(text: &OsStr) -> Result<Self, Self::Error> {
     if text.is_empty() {
       return Err(Error::OutputTargetEmpty);
-    };
+    }
 
     if text == OsStr::new("-") {
       Ok(Self::Stdout)

src/peer/client.rs

@@ -97,7 +97,7 @@ impl Client {
       {
         return Err(Error::PeerUtMetadataNotSupported);
       }
-    };
+    }
 
     self.extension_handshake.replace(handshake);
 
@@ -117,7 +117,7 @@ impl Client {
       extended::ut_metadata::MsgType::Request | extended::ut_metadata::MsgType::Reject => {
         return Ok(())
       }
-    };
+    }
 
     if let State::WantInfo(info_buf) = &mut self.state {
       let piece = info_buf.len() / extended::UtMetadata::PIECE_LENGTH;
@@ -667,7 +667,7 @@ mod tests {
 
     assert_matches!(
       join_handle.join().unwrap(),
-      Err(Error::PeerUtMetadataInfoLength { .. })
+      Err(Error::PeerUtMetadataInfoLength)
     );
   }
 }

src/subcommand/torrent/create/create_step.rs

@@ -7,7 +7,7 @@ pub(crate) enum CreateStep<'a> {
   Writing { output: &'a OutputTarget },
 }
 
-impl<'a> Step for CreateStep<'a> {
+impl Step for CreateStep<'_> {
   fn n(&self) -> usize {
     match self {
       Self::Searching { .. } => 1,

src/subcommand/torrent/dump.rs

@@ -46,7 +46,7 @@ fn fmt_string(f: &mut Formatter, string: &[u8]) -> fmt::Result {
   Ok(())
 }
 
-impl<'a> Display for Fmt<'a> {
+impl Display for Fmt<'_> {
   fn fmt(&self, f: &mut Formatter) -> fmt::Result {
     match &self.0 {
       Value::Integer(integer) => write!(f, "{integer}")?,