Commit 4aca29e
committed
Add default no-op implementations for ViewLogsUrlProvider and ViewDashboardUrlProvider
PR #537 introduced ViewDashboardAction and ViewLogsAction which require
ViewDashboardUrlProvider and ViewLogsUrlProvider to be bound in the Guice
injector. However, these bindings were not provided in BackfilaServiceModule,
causing injection failures in downstream services like cash-server.
This change adds default no-op implementations that return '#' as placeholder
URLs. These satisfy Guice's dependency requirements and allow the service to
start successfully. Deployments can override these bindings with real
implementations that link to their actual logging and monitoring infrastructure.
Fixes cash-server InjectorTest failures.1 parent 0cbe75e commit 4aca29e
File tree
1 file changed
+31
-0
lines changed- service/src/main/kotlin/app/cash/backfila/service
1 file changed
+31
-0
lines changedLines changed: 31 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
12 | 14 | | |
13 | 15 | | |
| 16 | + | |
14 | 17 | | |
15 | 18 | | |
16 | 19 | | |
| |||
23 | 26 | | |
24 | 27 | | |
25 | 28 | | |
| 29 | + | |
26 | 30 | | |
27 | 31 | | |
28 | 32 | | |
| |||
68 | 72 | | |
69 | 73 | | |
70 | 74 | | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
71 | 80 | | |
72 | 81 | | |
73 | 82 | | |
| |||
88 | 97 | | |
89 | 98 | | |
90 | 99 | | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
0 commit comments