This PR enables Hikari connection pool metrics for database read

yyuan-squareup · svc-squareup-copybara · commit 6c11defab0c3 · 2025-02-27T14:42:17.000Z
replica.

GitOrigin-RevId: e7cae9afb03dde5d7cbf8acfaf3b049f1d3f52c1
diff --git a/misk-jdbc/src/main/kotlin/misk/jdbc/JdbcModule.kt b/misk-jdbc/src/main/kotlin/misk/jdbc/JdbcModule.kt
@@ -175,8 +175,7 @@ class JdbcModule @JvmOverloads constructor(
           deployment = deploymentProvider.get(),
           dataSourceDecorators = dataSourceDecoratorsProvider.get(),
           databasePool = databasePool,
-          // TODO provide metrics to the reader pool but need a different metric key prefix
-          collectorRegistry = if (isWriter) registry else null
+          collectorRegistry = registry,
         )
       }
     }).asSingleton()

Original file line number	Diff line number	Diff line change
`@@ -175,8 +175,7 @@ class JdbcModule @JvmOverloads constructor(`
`175`	`175`	`deployment = deploymentProvider.get(),`
`176`	`176`	`dataSourceDecorators = dataSourceDecoratorsProvider.get(),`
`177`	`177`	`databasePool = databasePool,`
`178`		`- // TODO provide metrics to the reader pool but need a different metric key prefix`
`179`		`- collectorRegistry = if (isWriter) registry else null`
	`178`	`+ collectorRegistry = registry,`
`180`	`179`	`)`
`181`	`180`	`}`
`182`	`181`	`}).asSingleton()`