add deprecation warning for put-deploy subcommand

Author: wojcik91

lib/cli/deploy.rs

@@ -32,6 +32,7 @@ pub async fn put_deploy(
     let rpc_id = parse::rpc_id(maybe_rpc_id);
     let verbosity = parse::verbosity(verbosity_level);
     let deploy = with_payment_and_session(deploy_params, payment_params, session_params, false)?;
+    #[allow(deprecated)]
     crate::put_deploy(rpc_id, node_address, verbosity, deploy)
         .await
         .map_err(CliError::from)
@@ -115,6 +116,7 @@ pub async fn send_deploy_file(
     let rpc_id = parse::rpc_id(maybe_rpc_id);
     let verbosity = parse::verbosity(verbosity_level);
     let deploy = crate::read_deploy_file(input_path)?;
+    #[allow(deprecated)]
     crate::put_deploy(rpc_id, node_address, verbosity, deploy)
         .await
         .map_err(CliError::from)
@@ -170,6 +172,7 @@ pub async fn transfer(
         payment_params,
         false,
     )?;
+    #[allow(deprecated)]
     crate::put_deploy(rpc_id, node_address, verbosity, deploy)
         .await
         .map_err(CliError::from)

lib/lib.rs

@@ -134,6 +134,7 @@ pub const MAX_SERIALIZED_SIZE_OF_DEPLOY: u32 = 1_024 * 1_024;
 /// Sends a JSON-RPC `account_put_deploy` request to the specified node.
 ///
 /// For details of the parameters, see [the module docs](crate#common-parameters).
+#[deprecated(since = "3.0.0", note = "use `put_transaction` instead")]
 pub async fn put_deploy(
     rpc_id: JsonRpcId,
     node_address: &str,

src/deploy/put.rs

@@ -8,10 +8,20 @@ use crate::{command::ClientCommand, common, Success};
 
 pub struct PutDeploy;
 
+static DEPRECATION_WARNING: &str = r#"
+#################################### WARNING ####################################
+#                                                                               #
+#        put-deploy subcommand is deprecated in favor of put-transaction        #
+#                    and will be removed in a future release                    #
+#                                                                               #
+#################################################################################
+"#;
+
 #[async_trait]
 impl ClientCommand for PutDeploy {
     const NAME: &'static str = "put-deploy";
-    const ABOUT: &'static str = "Create a deploy and send it to the network for execution";
+    const ABOUT: &'static str =
+        "[DEPRECATED: use `put-transaction` instead] Create a deploy and send it to the network for execution";
 
     fn build(display_order: usize) -> Command {
         let subcommand = Command::new(Self::NAME)
@@ -27,6 +37,9 @@ impl ClientCommand for PutDeploy {
     }
 
     async fn run(matches: &ArgMatches) -> Result<Success, CliError> {
+        // show deprecation warning for each use of `put-deploy` subcommand
+        println!("{DEPRECATION_WARNING}");
+
         creation_common::show_simple_arg_examples_and_exit_if_required(matches);
         creation_common::show_json_args_examples_and_exit_if_required(matches);