Update linting + bad comment (#170)

* npm audit fix

* Bad code comment

* Update linting

* Update npm

Author: gRoussac

client-js/package-lock.json

@@ -227,9 +227,7 @@ pub fn change_security() -> EntryPoint {
             // Optional Arguments (can be added or omitted when calling):
             /*
             - "admin_list" : Vec<Key>
-            - "mint_and_burn_list" : Vec<Key>
             - "minter_list" : Vec<Key>
-            - "burner_list" : Vec<Key>
             - "none_list" : Vec<Key>
             */
         ],

contracts/contract/src/entry_points.rs

@@ -143,8 +143,7 @@ fn should_not_transfer_from_without_enough_allowance() {
     let error = builder.get_error().expect("should have error");
     assert!(
         matches!(error, CoreError::Exec(ExecError::Revert(ApiError::User(user_error))) if user_error == Cep18Error::InsufficientAllowance as u16),
-        "{:?}",
-        error
+        "{error:?}"
     );
 }
 

tests/src/allowance.rs

@@ -71,8 +71,8 @@ fn should_not_store_balances_or_allowances_under_account_after_install() {
 
     let named_keys = builder.get_named_keys_by_account_hash(*DEFAULT_ACCOUNT_ADDR);
 
-    assert!(!named_keys.contains(DICT_BALANCES), "{:?}", named_keys);
-    assert!(!named_keys.contains(DICT_ALLOWANCES), "{:?}", named_keys);
+    assert!(!named_keys.contains(DICT_BALANCES), "{named_keys:?}",);
+    assert!(!named_keys.contains(DICT_ALLOWANCES), "{named_keys:?}");
 }
 
 #[test]
@@ -104,7 +104,6 @@ fn should_fail_with_left_over_bytes_converted_into_60006() {
             error,
             CoreError::Exec(ExecError::Revert(ApiError::User(60006)))
         ),
-        "{:?}",
-        error
+        "{error:?}",
     );
 }

tests/src/install.rs

@@ -195,8 +195,7 @@ fn test_should_not_mint_above_limits() {
     let error = builder.get_error().expect("should have error");
     assert!(
         matches!(error, CoreError::Exec(ExecError::Revert(ApiError::User(user_error))) if user_error == Cep18Error::Overflow as u16),
-        "Should not mint above limits, but instead: {:?}",
-        error
+        "Should not mint above limits, but instead: {error:?}",
     );
 }
 
@@ -233,8 +232,7 @@ fn test_should_not_burn_above_balance() {
     let error = builder.get_error().expect("should have error");
     assert!(
         matches!(error, CoreError::Exec(ExecError::Revert(ApiError::User(user_error))) if user_error == Cep18Error::InsufficientBalance as u16),
-        "{:?}",
-        error
+        "{error:?}",
     );
 }
 
@@ -274,8 +272,7 @@ fn test_should_not_mint_or_burn_with_entrypoint_disabled() {
     let error = builder.get_error().expect("should have error");
     assert!(
         matches!(error, CoreError::Exec(ExecError::Revert(ApiError::User(user_error))) if user_error == 60016),
-        "{:?}",
-        error
+        "{error:?}",
     );
 
     let burn_request = ExecuteRequestBuilder::contract_call_by_hash(
@@ -294,8 +291,7 @@ fn test_should_not_mint_or_burn_with_entrypoint_disabled() {
     let error = builder.get_error().expect("should have error");
     assert!(
         matches!(error, CoreError::Exec(ExecError::Revert(ApiError::User(user_error))) if user_error == 60016),
-        "{:?}",
-        error
+        "{error:?}",
     );
 }
 
@@ -336,8 +332,7 @@ fn test_security_no_rights() {
     let error = builder.get_error().expect("should have error");
     assert!(
         matches!(error, CoreError::Exec(ExecError::Revert(ApiError::User(user_error))) if user_error == 60010),
-        "{:?}",
-        error
+        "{error:?}",
     );
 
     let passing_admin_mint_request = ExecuteRequestBuilder::contract_call_by_hash(
@@ -442,8 +437,7 @@ fn test_security_burner_rights() {
     let error = builder.get_error().expect("should have error");
     assert!(
         matches!(error, CoreError::Exec(ExecError::Revert(ApiError::User(user_error))) if user_error == 60010),
-        "{:?}",
-        error
+        "{error:?}",
     );
 
     // mint by admin
@@ -532,7 +526,6 @@ fn test_change_security() {
     let error = builder.get_error().expect("should have error");
     assert!(
         matches!(error, CoreError::Exec(ExecError::Revert(ApiError::User(user_error))) if user_error == 60010),
-        "{:?}",
-        error
+        "{error:?}",
     );
 }

tests/src/mint_and_burn.rs

@@ -128,8 +128,7 @@ fn should_not_transfer_more_than_owned_balance() {
     let error = builder.get_error().expect("should have error");
     assert!(
         matches!(error, CoreError::Exec(ExecError::Revert(ApiError::User(user_error))) if user_error == Cep18Error::InsufficientBalance as u16),
-        "{:?}",
-        error
+        "{error:?}",
     );
 
     let account_1_balance_after =
@@ -348,8 +347,7 @@ fn should_not_be_able_to_own_transfer() {
     let error = builder.get_error().expect("should have error");
     assert!(
         matches!(error, CoreError::Exec(ExecError::Revert(ApiError::User(user_error))) if user_error == 60017),
-        "{:?}",
-        error
+        "{error:?}",
     );
 }
 
@@ -383,8 +381,7 @@ fn should_not_be_able_to_own_transfer_from() {
     let error = builder.get_error().expect("should have error");
     assert!(
         matches!(error, CoreError::Exec(ExecError::Revert(ApiError::User(user_error))) if user_error == 60017),
-        "{:?}",
-        error
+        "{error:?}"
     );
 
     let sender_balance_before =
@@ -414,8 +411,7 @@ fn should_not_be_able_to_own_transfer_from() {
     let error = builder.get_error().expect("should have error");
     assert!(
         matches!(error, CoreError::Exec(ExecError::Revert(ApiError::User(user_error))) if user_error == 60017),
-        "{:?}",
-        error
+        "{error:?}"
     );
 }
 

tests/src/transfer.rs

@@ -125,7 +125,7 @@ pub(crate) fn get_test_account(ending_string_index: &str) -> (Key, AccountHash,
     match accounts {
         Some(account) => account,
         None => {
-            panic!("No account found for index {}", index);
+            panic!("No account found for index {index}");
         }
     }
 }

tests/src/utility/installer_request_builders.rs

@@ -17,10 +17,7 @@ pub fn message_topic(
     match query_result {
         StoredValue::MessageTopic(summary) => summary,
         _ => {
-            panic!(
-                "Stored value is not a message topic summary: {:?}",
-                query_result
-            );
+            panic!("Stored value is not a message topic summary: {query_result:?}",);
         }
     }
 }
@@ -41,6 +38,6 @@ pub fn message_summary(
 
     match query_result {
         StoredValue::Message(summary) => Ok(summary),
-        _ => panic!("Stored value is not a message summary: {:?}", query_result),
+        _ => panic!("Stored value is not a message summary: {query_result:?}"),
     }
 }