fix: resolve errors and add unit test

Author: castdrian

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@castdrian/kdapi",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "type": "module",
   "description": "kpop idol and group profiles dataset generator",
   "main": "dist/index.js",
@@ -21,7 +21,9 @@
     "scrape:prod": "bun src/cli.ts scrape --delay 4000 --batch-size 5 --cache",
     "scrape:force": "bun src/cli.ts scrape --delay 4000 --batch-size 5 --force",
     "build": "bun build ./src/index.ts --outdir ./dist --target node && tsc --project tsconfig.build.json",
-    "prepublishOnly": "bun run build"
+    "prepublishOnly": "bun run build",
+    "test": "bun test",
+    "test:watch": "bun test --watch"
   },
   "devDependencies": {
     "@types/uuid": "^10.0.0",

src/index.ts

@@ -38,12 +38,11 @@ idolSearcher.indexEntities(
 			entity.names.japanese,
 			entity.names.chinese,
 			// Add group names to search terms
-			...(entity.groups
-				?.flatMap((g) => [
-					g.name, // Group name by itself
-					`${entity.names.stage} ${g.name}`, // "Name Group"
-					`${g.name} ${entity.names.stage}`, // "Group Name"
-				]) || []),
+			...(entity.groups?.flatMap((g) => [
+				g.name, // Group name by itself
+				`${entity.names.stage} ${g.name}`, // "Name Group"
+				`${g.name} ${entity.names.stage}`, // "Group Name"
+			]) || []),
 		].filter((name): name is string => name !== null),
 );
 
@@ -52,15 +51,15 @@ groupSearcher.indexEntities(
 	(entity) => entity.id,
 	(entity) =>
 		[
-			entity.groupInfo.names.stage,
-			entity.groupInfo.names.korean,
-			entity.groupInfo.names.japanese,
-			entity.groupInfo.names.chinese,
-			entity.groupInfo.fandomName,
+			entity.groupInfo?.names?.stage,
+			entity.groupInfo?.names?.korean,
+			entity.groupInfo?.names?.japanese,
+			entity.groupInfo?.names?.chinese,
+			entity.groupInfo?.fandomName,
 			entity.company?.current,
-			...(entity.company?.history.map((h) => h.name) || []),
-			...entity.memberHistory.currentMembers.map((m) => m.name),
-			...(entity.memberHistory.formerMembers?.map((m) => m.name) || []),
+			...(entity.company?.history ?? []).map((h) => h.name),
+			...(entity.memberHistory?.currentMembers ?? []).map((m) => m.name),
+			...(entity.memberHistory?.formerMembers ?? []).map((m) => m.name),
 		].filter((name): name is string => name !== null),
 );
 

test/search.test.ts

@@ -0,0 +1,68 @@
+import { describe, expect, test } from "bun:test";
+import { type Idol, type Group, search } from "@src/index";
+
+describe("Fuzzy Search", () => {
+	const testJapaneseName = "ステイシー";
+
+	test("should handle null company data", () => {
+		const results = search("company");
+		expect(results).toBeDefined();
+		// Should not throw any errors
+	});
+
+	test("should search by idol name", () => {
+		const results = search("sumin");
+		expect(results.length).toBeGreaterThan(0);
+		expect(results.some((r) => r.type === "idol")).toBe(true);
+	});
+
+	test("should search by idol name + group", () => {
+		const results = search("sumin stayc");
+		expect(results.length).toBeGreaterThan(0);
+		expect(
+			results.some(
+				(r) =>
+					r.type === "idol" &&
+					(r.item as Idol).groups?.some((g) => g.name.toLowerCase().includes("fromis")),
+			),
+		).toBe(true);
+	});
+
+	test("should search by group name", () => {
+		const results = search("stayc");
+		expect(results.length).toBeGreaterThan(0);
+		expect(results.some((r) => r.type === "group")).toBe(true);
+	});
+
+	test("should handle Korean characters", () => {
+		const results = search("스테이씨");
+		expect(results.length).toBeGreaterThan(0);
+	});
+
+	test("should handle Japanese characters", () => {
+		const results = search(testJapaneseName);
+		expect(results.length).toBeGreaterThan(0);
+		expect(
+			results.some(
+				(r) =>
+					r.type === "group" &&
+					(r.item as Group).groupInfo?.names?.stage
+						?.toLowerCase()
+						.includes("twice"),
+			),
+		).toBe(true);
+	});
+
+	test("should handle empty/null values", () => {
+		expect(() => search("")).not.toThrow();
+		expect(() => search(" ")).not.toThrow();
+	});
+
+	test("should filter by type", () => {
+		const idolResults = search("jin", { type: "idol" });
+		expect(idolResults.every((r) => r.type === "idol")).toBe(true);
+
+		const groupResults = search("bts", { type: "group" });
+		expect(groupResults.every((r) => r.type === "group")).toBe(true);
+	});
+});

tsconfig.json

@@ -22,12 +22,13 @@
 			]
 		},
 		"outDir": "dist",
-		"rootDir": "src",
+		"rootDir": ".",
 		"declaration": true,
 		"emitDeclarationOnly": true
 	},
 	"include": [
-		"src/**/*"
+		"src/**/*",
+		"test/**/*"
 	],
 	"exclude": [
 		"node_modules",