Now can downgrade AsTypeReference to an expression & rename it

Author: stakx

src/Castle.Core/DynamicProxy/Contributors/MixinContributor.cs

@@ -1,4 +1,4 @@
-// Copyright 2004-2021 Castle Project - http://www.castleproject.org/
+// Copyright 2004-2025 Castle Project - http://www.castleproject.org/
 // 
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -114,7 +114,7 @@ private GetTargetExpressionDelegate BuildGetTargetExpression()
 			}
 
 			return (c, m) => new NullCoalescingOperatorExpression(
-			                 	new AsTypeReference(c.GetField("__target"), m.DeclaringType),
+			                 	new AsTypeExpression(c.GetField("__target"), m.DeclaringType),
 			                 	fields[m.DeclaringType]);
 		}
 

…rs/Emitters/SimpleAST/AsTypeReference.cs …s/Emitters/SimpleAST/AsTypeExpression.cssrc/Castle.Core/DynamicProxy/Generators/Emitters/SimpleAST/AsTypeReference.cs renamed to src/Castle.Core/DynamicProxy/Generators/Emitters/SimpleAST/AsTypeExpression.cs src/Castle.Core/DynamicProxy/Generators/Emitters/SimpleAST/AsTypeReference.cs renamed to src/Castle.Core/DynamicProxy/Generators/Emitters/SimpleAST/AsTypeExpression.cs

@@ -21,36 +21,21 @@ namespace Castle.DynamicProxy.Generators.Emitters.SimpleAST
 	using System.Reflection.Emit;
 
 	[DebuggerDisplay("{reference} as {type}")]
-	internal class AsTypeReference : Reference
+	internal class AsTypeExpression : IExpression
 	{
 		private readonly Reference reference;
 		private readonly Type type;
 
-		public AsTypeReference(Reference reference, Type type)
-			: base(type)
+		public AsTypeExpression(Reference reference, Type type)
 		{
 			this.reference = reference;
 			this.type = type;
 		}
 
-		public override void EmitAddress(ILGenerator gen)
-		{
-			// It does not make sense to take the address of a cast expression.
-			// The C# language would also forbid address-taking of the form `&(x as T)`.
-			throw new NotSupportedException();
-		}
-
-		public override void Emit(ILGenerator gen)
+		public void Emit(ILGenerator gen)
 		{
 			reference.Emit(gen);
 			gen.Emit(OpCodes.Isinst, type);
 		}
-
-		public override void EmitStore(IExpression value, ILGenerator gen)
-		{
-			// It does not make sense to assign a value to the result of a cast expression.
-			// The C# language would also forbid assignments of the form `(x as T) = y`.
-			throw new NotSupportedException();
-		}
 	}
 }

src/Castle.Core/DynamicProxy/Generators/InterfaceProxyWithTargetInterfaceGenerator.cs

@@ -63,7 +63,7 @@ protected override InterfaceProxyWithoutTargetContributor GetContributorForAddit
 
 		private IExpression GetTarget(ClassEmitter @class, MethodInfo method)
 		{
-			return new AsTypeReference(@class.GetField("__target"), method.DeclaringType);
+			return new AsTypeExpression(@class.GetField("__target"), method.DeclaringType);
 		}
 	}
 }

src/Castle.Core/DynamicProxy/Generators/InvocationTypeGenerator.cs

@@ -96,7 +96,7 @@ protected virtual MethodInvocationExpression GetCallbackMethodInvocation(Abstrac
 				return contributor.GetCallbackMethodInvocation(invocation, args, targetField, invokeMethodOnTarget);
 			}
 			var methodOnTargetInvocationExpression = new MethodInvocationExpression(
-				new AsTypeReference(targetField, callbackMethod.DeclaringType),
+				new AsTypeExpression(targetField, callbackMethod.DeclaringType),
 				callbackMethod,
 				args) { VirtualCall = true };
 			return methodOnTargetInvocationExpression;