Merge pull request #9 from derekwheel/deno_worker_unstable

add denoUnstable flag to DenoWorkerOptions

Author: KallynGowdy

src/DenoWorker.spec.ts

@@ -4,6 +4,7 @@ import path from 'path';
 import { URL } from 'url';
 import { MessageChannel, MessagePort } from './MessageChannel';
 import psList from 'ps-list';
+import child_process from 'child_process';
 
 console.log = jest.fn();
 jest.setTimeout(10000);
@@ -112,6 +113,87 @@ describe('DenoWorker', () => {
                 message: 'Hello',
             });
         });
+
+        describe('denoUnstable', async () => {
+            afterEach(() => {
+                jest.clearAllMocks();
+            });
+
+            it('should not include the --unstable flag by default', async () => {
+                const spawnSpy = jest.spyOn(child_process, 'spawn');
+
+                worker = new DenoWorker(echoScript);
+
+                let resolve: any;
+                let promise = new Promise((res, rej) => {
+                    resolve = res;
+                });
+                worker.onmessage = (e) => {
+                    resolve();
+                };
+
+                worker.postMessage({
+                    type: 'echo',
+                    message: 'Hello',
+                });
+
+                await promise;
+
+                const call = spawnSpy.mock.calls[0];
+                const [_deno, args] = call;
+                expect(args).not.toContain('--unstable');
+            });
+
+            it('should not include the --unstable flag by when denoUnstable is false', async () => {
+                const spawnSpy = jest.spyOn(child_process, 'spawn');
+
+                worker = new DenoWorker(echoScript, { denoUnstable: false });
+
+                let resolve: any;
+                let promise = new Promise((res, rej) => {
+                    resolve = res;
+                });
+                worker.onmessage = (e) => {
+                    resolve();
+                };
+
+                worker.postMessage({
+                    type: 'echo',
+                    message: 'Hello',
+                });
+
+                await promise;
+
+                const call = spawnSpy.mock.calls[0];
+                const [_deno, args] = call;
+                expect(args).not.toContain('--unstable');
+            });
+
+            it('should allow include the --unstable flag when denoUnstable is true', async () => {
+                const spawnSpy = jest.spyOn(child_process, 'spawn');
+
+                worker = new DenoWorker(echoScript, { denoUnstable: true });
+
+                let resolve: any;
+                let promise = new Promise((res, rej) => {
+                    resolve = res;
+                });
+                worker.onmessage = (e) => {
+                    resolve();
+                };
+
+                worker.postMessage({
+                    type: 'echo',
+                    message: 'Hello',
+                });
+
+                await promise;
+
+                const call = spawnSpy.mock.calls[0];
+                const [_deno, args] = call;
+                expect(args).toContain('--unstable');
+            });
+        });
     });
 
     describe('data types', () => {
@@ -440,6 +522,8 @@ describe('DenoWorker', () => {
 
 async function getDenoProcesses() {
     const list = await psList();
-    const denoProcesses = list.filter((p) => /^deno/.test(p.name));
+    const denoProcesses = list.filter(
+        (p) => /^deno/.test(p.name) && p.cmd !== 'deno lsp'
+    );
     return denoProcesses;
 }

src/DenoWorker.ts

@@ -55,6 +55,11 @@ export interface DenoWorkerOptions {
      */
     logStderr: boolean;
 
+    /**
+     * Whether to use Deno's unstable features
+     */
+    denoUnstable: boolean;
+
     /**
      * The permissions that the Deno worker should use.
      */
@@ -152,6 +157,7 @@ export class DenoWorker {
                 reload: process.env.NODE_ENV !== 'production',
                 logStdout: true,
                 logStderr: true,
+                denoUnstable: false,
                 permissions: {},
             },
             options || {}
@@ -242,7 +248,7 @@ export class DenoWorker {
             let runArgs = [] as string[];
 
             addOption(runArgs, '--reload', this._options.reload);
-            // addOption(runArgs, '--unstable', true);
+            addOption(runArgs, '--unstable', this._options.denoUnstable);
 
             if (this._options.permissions) {
                 addOption(