feat: unhardcode RM-13 night vision enhancement as RECON_VISION item flag, add to active power armor helmets (#8256)

* feat: unharded RM-13 night vision enhancement as `RECON_VISION` item flag, add to active power armor helmets

* Add flag descriptions

Author: chaosvolt

data/json/flags.json

@@ -1649,7 +1649,14 @@
   {
     "id": "GNV_EFFECT",
     "type": "json_flag",
-    "context": [  ]
+    "context": [  ],
+    "info": "This gear <good>enhances your vision</good> when worn, and <info>tints your field of view</info>."
+  },
+  {
+    "id": "RECON_VISION",
+    "type": "json_flag",
+    "context": [  ],
+    "info": "This gear <good>enhances your vision</good> when worn."
   },
   {
     "id": "HELMET_COMPAT",
@@ -1699,7 +1706,8 @@
   {
     "id": "IR_EFFECT",
     "type": "json_flag",
-    "context": [  ]
+    "context": [  ],
+    "info": "This gear allows you to <good>see heat signatures</good> when worn."
   },
   {
     "id": "IS_ARMOR",

data/json/items/armor/power_armor.json

@@ -271,7 +271,7 @@
     "type": "TOOL_ARMOR",
     "name": { "str": "power armor helmet (active)", "str_pl": "power armor helmets (active)" },
     "description": "A fully enclosed combat helmet for hazardous environments, this was designed to fit with a powered exoskeleton, using cameras to expand visual range.  In practice, the cameras were unreliable and easily fouled.  The environmental controls function best with direct-skin contact.",
-    "extend": { "flags": [ "THERMOMETER", "CLIMATE_CONTROL", "TRADER_AVOID" ] },
+    "extend": { "flags": [ "THERMOMETER", "RECON_VISION", "CLIMATE_CONTROL", "TRADER_AVOID" ] },
     "power_draw": 500000,
     "qualities": [ [ "GLARE", 2 ] ],
     "revert_to": "power_armor_helmet_basic",
@@ -327,7 +327,7 @@
     "type": "TOOL_ARMOR",
     "name": { "str": "heavy power armor helmet (active)", "str_pl": "heavy power armor helmets (active)" },
     "description": "An extremely heavy-duty fully enclosed combat helmet for hazardous environments, this was designed to fit with a powered exoskeleton.  In the field, soldiers reported that the protection was not worth the awkward size and limited visuals.  The environmental controls function best with direct-skin contact.",
-    "extend": { "flags": [ "THERMOMETER", "CLIMATE_CONTROL", "TRADER_AVOID" ] },
+    "extend": { "flags": [ "THERMOMETER", "RECON_VISION", "CLIMATE_CONTROL", "TRADER_AVOID" ] },
     "power_draw": 750000,
     "qualities": [ [ "GLARE", 2 ] ],
     "revert_to": "power_armor_helmet_heavy",
@@ -383,7 +383,7 @@
     "type": "TOOL_ARMOR",
     "name": { "str": "light power armor helmet (active)", "str_pl": "light power armor helmets (active)" },
     "description": "This full-enclosure helmet was designed based on commercial diving equipment, in response to complaints that earlier designs were impossible to use in combat.  While still a little more restrictive than regular combat headgear - and frustrating should your nose itch - this one received far better reviews from soldiers.  Sadly, civilization ended before they could roll out in significant numbers.  The environmental controls function best with direct-skin contact.",
-    "extend": { "flags": [ "THERMOMETER", "CLIMATE_CONTROL", "TRADER_AVOID" ] },
+    "extend": { "flags": [ "THERMOMETER", "RECON_VISION", "CLIMATE_CONTROL", "TRADER_AVOID" ] },
     "power_draw": 250000,
     "qualities": [ [ "GLARE", 1 ] ],
     "revert_to": "power_armor_helmet_light",

data/json/items/tool_armor.json

@@ -896,6 +896,7 @@
       "ALARMCLOCK",
       "SWIM_GOGGLES",
       "SUN_GLASSES",
+      "RECON_VISION",
       "RAD_PROOF",
       "ELECTRIC_IMMUNE",
       "THERMOMETER",

src/character.cpp

@@ -1966,7 +1966,7 @@ void Character::recalc_sight_limits()
     for( const mutation_branch *mut : cached_mutations ) {
         best_bonus_nv = std::max( best_bonus_nv, mut->night_vision_range );
     }
-    if( is_wearing( itype_rm13_armor_on ) ||
+    if( worn_with_flag( flag_RECON_VISION ) ||
         ( is_mounted() && mounted_creature->has_flag( MF_MECH_RECON_VISION ) ) ) {
         best_bonus_nv = std::max( best_bonus_nv, 10.0f );
     }

src/flag.cpp

@@ -283,6 +283,7 @@ const flag_id flag_REACH3( "REACH3" );
 const flag_id flag_REACH_ATTACK( "REACH_ATTACK" );
 const flag_id flag_REBREATHER( "REBREATHER" );
 const flag_id flag_RECHARGE( "RECHARGE" );
+const flag_id flag_RECON_VISION( "RECON_VISION" );
 const flag_id flag_REDUCED_BASHING( "REDUCED_BASHING" );
 const flag_id flag_REDUCED_WEIGHT( "REDUCED_WEIGHT" );
 const flag_id flag_RELOAD_AND_SHOOT( "RELOAD_AND_SHOOT" );

src/flag.h

@@ -285,6 +285,7 @@ extern const flag_id flag_REACH;
 extern const flag_id flag_REACH_ATTACK;
 extern const flag_id flag_REBREATHER;
 extern const flag_id flag_RECHARGE;
+extern const flag_id flag_RECON_VISION;
 extern const flag_id flag_REDUCED_BASHING;
 extern const flag_id flag_REDUCED_WEIGHT;
 extern const flag_id flag_RELOAD_AND_SHOOT;