Replies: 1 comment
-
|
Is this being worked on? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Purpose of change
after #3489, there has been numerous issues and fixes with count-by-charges ("the stackable") items:
std::clamp" #4007however, they all does not solve the fundemental issue: they work on different APIs.
game_object::detachitem::splithttps://github.com/cataclysmbnteam/Cataclysm-BN/blob/6bff212696c4832de7168d10e8b7f6db6de09e51/src/activity_actor.cpp#L1179-L1185
For every time an item may be stackable, this logic needs to be duplicated with
item::count_by_charges.This is problemetic in numerous ways:
Proposed Change
detachsplitBeta Was this translation helpful? Give feedback.
All reactions