perf(UI): add sleep time skip option with safe fallback#8240
Draft
scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
Draft
perf(UI): add sleep time skip option with safe fallback#8240scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
scarf005 wants to merge 1 commit intocataclysmbn:mainfrom
Conversation
ba6b42a to
f3e41b2
Compare
Collaborator
|
Not sure if this changes the course here, but #8203 is going to swap the options under Debug->Performance to a new Performance tab, since we're getting many more performance options in general. |
Member
Author
no worries, this PR will be ready tomorrow |
Co-authored-by: chatgpt-codex-connector[bot] <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Assisted-by: openai/gpt-5.3-codex on opencode
f3e41b2 to
b7197b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
Add a sleep performance option that skips rendering-heavy sleep turns while preserving gameplay effects and a safety fallback when hostiles are nearby.
Describe the solution (The How)
SLEEP_SKIP_TIMEoption (Skip Time When Sleeping) with requested description text.Describe alternatives you've considered
do_turn()during sleep skip; rejected due to instability/segfault risk in tests.Testing
cmake --build --preset linux-full --target astylecmake --build --preset linux-full --target cataclysm-bn-tiles cata_test-tiles./out/build/linux-full/tests/cata_test-tiles "[sleep][perf]"./out/build/linux-full/tests/cata_test-tiles "Vehicle charging station"Additional context
N/A
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.