feat: Make fruit trees transplantable, take 2#8241
Open
DeinonychusDiscord wants to merge 21 commits intocataclysmbn:mainfrom
Open
feat: Make fruit trees transplantable, take 2#8241DeinonychusDiscord wants to merge 21 commits intocataclysmbn:mainfrom
DeinonychusDiscord wants to merge 21 commits intocataclysmbn:mainfrom
Conversation
Contributor
|
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
Collaborator
|
In my opinion, tree replanting should wait until is merged, and do re/planting like its done with in for crops, with items + vars, to avoid needing a bunch of json files / modifications |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
retry of #8236
Extension of transplantable bushes, this makes trees transplantable as well.
Describe the solution (The How)
You can manually dig up a tree with a proper shovel [dig 3], but it'll take 8 hours, as will replanting. This is something anyone can do. It's small enough [for gameplay purposes, handwaving a tree's actual volume and weight] to occupy one Cargo Space per tree so you can at least haul it home in your deathmobile.
You can also use the new Tree Spade mounted vehicle part, which only takes 2 hours to dig and replant. Guaranteed spawns of tree spade farming and utility vehicles exist at the Apple Orchard Processing Stall parking lot.
You can craft the tree spade if you find one of the two books the recipe is written in. Takes four hours and some welding. The parts aren't terribly hard to find, and there's both a normal recipe and an "improvised" recipe depending on what's available to you.
Describe alternatives you've considered
I honestly considered just the tree spade autolearn and making it super simple to build, but that doesn't feel particularly balanced or believable considering what it is.
I also considered for player convenience, just making it take an hour to dig up and replant a tree, but that felt incredibly immersion-breaking as well as unbalanced considering what you're actually doing.
Testing
This is my second attempt at this PR after github-specific issues stalled the first attempt.
With guidance from Discord I've done things differently this time. More importantly, I directly tested all the github-ready files for this huge project before attempting to push a PR.
I made the mistake the first time of simply assuming I had everything I needed, and that resulted in me missing two crucial files needed for the content to work properly, as well as missing a very small missing comma mistake.
Opened up bn with the changes, it is no longer throwing any issues on my end, and unlike last time, I did not update the branch before uploading files - fingers crossed that this time it passes autofix and all cmakes.
Additional context
I'm well aware this is intensely json-heavy, and it's not ideal.
However, this approach gets transplanting in the game at all , which is something multiple players from the discord have expressed interest in.
Later on, we can hopefully luafy both bushes and trees into dynamic variable entries that don't require individual json entries for each terrain type [which gets painful when you include the harvested versions!]
I look forward to the day that happens. Until then, players will at least have the ability at all to dig up any tree from apple to coca and replant it two ways.
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.