Infinite loop due to URL encoding issue #922
Description
I've discovered that when using the "test idp connectivity" mode, its possible for users to get into a redirect loop until the login succeeds.
The logs look something like this:
/login/index.php/login/index.php?loginredirect=1(about 3 of these logs)/login/index.php?loginredirect=1& saml=on(literal text it says) - probably about 20 or so of these logs- 5-6 logs of SimpleSaml sending saml request, across 3 different hosts
- finally 2 logins messaes saml_login_complete found user / login complete
Somewhere in the redirect it's not properly encoding the saml=on param and so this isn't being detected and causing the loop
Further testing shows this can be triggered by just going to the login page with any urlparameter e.g. /login/index.php?abc=123