[MOODLE_39_STABLE] version.php and db/upgrade.php latest version numbers are inconsistent

[mlynn-lp]

In db/upgrade.php we have:
if ($oldversion < 2024092001) { // Due to simplesaml library update, we need to purge all existing sessions. $DB->delete_records('auth_saml2_kvstore', ['type' => 'session']); upgrade_plugin_savepoint(true, 2024092001, 'auth', 'saml2'); }
But in version.php we have:
$plugin->version = 2024090901; // The current plugin version (Date: YYYYMMDDXX).

When I tried to upgrade I get the error: upgrade tried to set version higher than version.php

Should the version number be updated in version.php or the number downgraded to the same number in db/upgrade.php?

[danmarsden]

@matthewhilton @brendanheywood - looks like a regression from 6dc06c3

I think that we just revert that patch on the 3.9 branch (leaving the updated saml lib but removing the patch in the upgrade.php file.) - we don't fully support it anymore as it relates to an unsupported Moodle release.