Skip to content

Commit 90e5cfa

Browse files
committed
change: include patch version when bulk updating libraries
1 parent 70af5d2 commit 90e5cfa

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

classes/task/update_library_task.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ public function execute() {
9191
$librariescache = $ajax->editor->getLatestGlobalLibrariesData();
9292

9393
$library = $DB->get_record('hvp_libraries_hub_cache', ['machine_name' => $machinename]);
94-
mtrace("Successfully updated {$librarytitle} to version {$library->major_version}.{$library->minor_version}");
94+
$version = "{$library->major_version}.{$library->minor_version}.{$library->patch_version}";
95+
mtrace("Successfully updated {$librarytitle} to version {$version}");
9596
}
9697
}

update_libraries.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
$token = \H5PCore::createToken('editorajax');
5858
$ajax->core->updateContentTypeCache();
5959

60-
$sql = "SELECT DISTINCT lhc.machine_name, lhc.title, lhc.major_version, lhc.minor_version
60+
$sql = "SELECT DISTINCT lhc.machine_name, lhc.title, lhc.major_version, lhc.minor_version, lhc.patch_version
6161
FROM {hvp_libraries_hub_cache} lhc
6262
JOIN {hvp_libraries} l
6363
ON lhc.machine_name = l.machine_name
@@ -70,6 +70,7 @@
7070
'machine_name' => $library->machine_name,
7171
'major_version' => $library->major_version,
7272
'minor_version' => $library->minor_version,
73+
'patch_version' => $library->patch_version,
7374
]);
7475
});
7576

@@ -92,7 +93,7 @@
9293
]);
9394
\core\task\manager::queue_adhoc_task($updatelibrarytask, true);
9495

95-
$version = "{$library->major_version}.{$library->minor_version}";
96+
$version = "{$library->major_version}.{$library->minor_version}.{$library->patch_version}";
9697
$queuedlibraries[$librarytitle] = $version;
9798
}
9899

0 commit comments

Comments
 (0)