Fix for #199

Author: x-iy

classes/metric/online_users_metric.php

@@ -106,18 +106,18 @@ public function generate_metric_items($backwardperiod, $finishtime = null, ?\pro
         ];
 
         $interval = $secondsinterval[$frequency];
-        $sql = 'WITH user_data AS (
+        $sql = "WITH user_data AS (
                   SELECT floor(timecreated / :interval ) * :intervaldup AS time, userid
                     FROM {logstore_standard_log}
                    WHERE timecreated >= :starttime
                      AND timecreated <= :finishtime
-                     AND action = "loggedin"
+                     AND action = 'loggedin'
                 )
 
                 SELECT user_data.time as time, COUNT(DISTINCT(user_data.userid)) as value
                   FROM user_data
               GROUP BY user_data.time
-              ORDER BY user_data.time ASC';
+              ORDER BY user_data.time ASC";
         $rs = $DB->get_recordset_sql($sql,
                 ['interval' => $interval, 'intervaldup' => $interval, 'starttime' => $starttime, 'finishtime' => $finishtime]);
         $metricitems = [];

db/install.php

@@ -27,6 +27,9 @@
  * Function to install tool_cloudmetrics.
  */
 function xmldb_tool_cloudmetrics_install() {
+    if (PHPUNIT_TEST) {
+        return;
+    }
     $backfilltask = new \tool_cloudmetrics\task\autobackfill_metrics_task();
     \core\task\manager::queue_adhoc_task($backfilltask);
 }