Merge pull request #169 from catalyst/reusable-workflows-master

Add reusable workflow (master)

Author: dmitriim

.github/workflows/ci.yml

@@ -0,0 +1,10 @@
+# .github/workflows/ci.yml
+name: ci
+
+on: [push, pull_request]
+
+jobs:
+  ci:
+    uses: catalyst/catalyst-moodle-workflows/.github/workflows/ci.yml@main
+    with:
+      disable_behat: true

.travis.yml

@@ -1,4 +1,6 @@
-[![Build Status](https://travis-ci.org/catalyst/moodle-tool_crawler.svg?branch=master)](https://travis-ci.org/catalyst/moodle-tool_crawler)
+# moodle-tool_crawler
+
+![GitHub Workflow Status (branch)](https://img.shields.io/github/workflow/status/catalyst/moodle-tool_crawler/ci/master?label=ci)
 
 * [What is this?](#what-is-this)
 * [How does it work?](#how-does-it-work)

README.md

@@ -18,6 +18,7 @@
  * Link checker robot plugin uninstall script.
  *
  * @package    tool_crawler
+ * @copyright  2019 Nicolas Roeser
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 

db/uninstall.php

@@ -229,7 +229,8 @@ public function test_uri_escaping() {
                 preg_quote('href="' . $escapedexpected . '">' . $escapedexpected . '</a></small>', '@') .
                 '@';
 
-        self::assertRegExp($expectedpattern, $page);
+        // Workaround to ensure greater compatbilitiy since assertRegExp is deprecated.
+        self::assertTrue(preg_match($expectedpattern, $page) === 1);
     }
 
     /**
@@ -274,7 +275,9 @@ public function test_redirection_uri_escaping() {
                 '.*' .
                 preg_quote('<br>Redirect: <a href="' . $escapedredirecturl . '">' . $escapedredirecturl . '</a></h2>', '@') .
                 '@';
-        self::assertRegExp($expectedpattern, $page);
+
+        // Workaround to ensure greater compatbilitiy since assertRegExp is deprecated.
+        self::assertTrue(preg_match($expectedpattern, $page) === 1);
     }
 
     /**
@@ -570,7 +573,7 @@ public function url_validity_check_provider() {
      * Check url validity
      *
      * @param string $url the url to test
-     * @param $expected the expected result
+     * @param bool $expected the expected result
      */
     public function test_invalid_url($url, $expected) {
         $baseurl = 'https://www.example.com/moodle';
@@ -599,8 +602,8 @@ public function page_title_validity_check_provider() {
      *
      * Test for Issue #143: invalid character in page title.
      *
-     * @param $url the url to test
-     * @param $expected
+     * @param array $node The node to test.
+     * @param string $expected
      */
     public function test_check_page_title_validity($node, $expected) {
         $this->resetAfterTest(true);

tests/phpunit/robot_crawler_test.php

@@ -30,6 +30,7 @@
 $plugin->version   = 2020101301;        // The current plugin version (Date: YYYYMMDDXX)
 $plugin->release   = 2020101301;        // The current plugin version (Date: YYYYMMDDXX)
 $plugin->requires  = 2016021800;        // Requires this Moodle version.
+$plugin->supported = [34, 401];
 $plugin->component = 'tool_crawler'; // To check on upgrade, that module sits in correct place.
 $plugin->maturity  = MATURITY_STABLE;
 $plugin->dependencies = array(