Skip to content

Refine the doubling logic in sample set #418

@duyhuynhdev

Description

@duyhuynhdev

Currently the doubling logic currently doesn't care how many events in a sample, as long as the sample's index is even it will be dropped.

  • For example:
    If we have sample list as below:
    0 - 10 events
    1 - 1000000 events
    2 - 10 events
    3 - 10 events
    If we want to half that right now the logic would end up with
    0 - 10 events
    2 - 10- events

The important sample and a significant of event has been removed and its could not show the bottleneck (see #204)

So that the logic for doubling should be changed. Instead of dropping every second row we can merge them instead by

  1. Adding the event counts
    For example :
    0 - 10 events
    1 - 1000000 events
    Would become
    1 - 1000010 events

  2. Picking the stack of the one which is bigger

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions