Removed legacy cron function and deprecated cron_trace_time_and_memory

In Moodle 4.2, cron_trace_time_and_memory has been replaced by a
different function in a namespaced location, and you get deprecation
warnings for including cronlib.php as well as for calling the function.

This change removes the old cron function in lib.php, and changes
the code that calls cron_trace_time_and_memory so that it uses the
old method prior to 4.2, and the new one after.

Author: sammarshallou

classes/task/delete_local_empty_directories.php

@@ -30,8 +30,6 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->libdir.'/cronlib.php');
-
 class delete_local_empty_directories  extends task {
 
     /** @var string $stringname  */
@@ -42,6 +40,8 @@ class delete_local_empty_directories  extends task {
      * @throws coding_exception
      */
     public function execute() {
+        global $CFG;
+
         if (!$this->enabled_tasks()) {
             return;
         }
@@ -51,7 +51,13 @@ public function execute() {
             return;
         }
         $filesystem = new $this->config->filesystem();
-        cron_trace_time_and_memory();
+        if ($CFG->version < 2023042400) {
+            // This function and library was deprecated in Moodle 4.2.
+            require_once($CFG->libdir . '/cronlib.php');
+            cron_trace_time_and_memory();
+        } else {
+            \core\cron::trace_time_and_memory();
+        }
         $filesystem->delete_empty_dirs();
     }
 }

lib.php

@@ -69,22 +69,6 @@
 define('TOOL_OBJECTFS_DELETE_EXTERNAL_TRASH', 1);
 define('TOOL_OBJECTFS_DELETE_EXTERNAL_FULL', 2);
 
-// Legacy cron function.
-function tool_objectfs_cron() {
-    mtrace('RUNNING legacy cron objectfs');
-    global $CFG;
-    if ($CFG->branch <= 26) {
-        // Unlike the task system, we do not get fine grained control over
-        // when tasks/manipulators run. Every cron we just run all the manipulators.
-        (new manipulator_builder())->execute_all();
-
-        \tool_objectfs\local\report\objectfs_report::cleanup_reports();
-        \tool_objectfs\local\report\objectfs_report::generate_status_report();
-    }
-
-    return true;
-}
-
 /**
  * Sends a plugin file to the browser.
  * @param $course

tests/local/tasks_test.php

@@ -32,13 +32,6 @@ protected function tearDown(): void {
         ob_end_clean();
     }
 
-    public function test_run_legacy_cron() {
-        $config = manager::get_objectfs_config();
-        $config->enabletasks = true;
-        manager::set_objectfs_config($config);
-        $this->assertTrue(tool_objectfs_cron());
-    }
-
     public function test_run_scheduled_tasks() {
         global $CFG;
         // If tasks not implemented.