Skip to content

Commit 330895a

Browse files
Refactor microscopy response series tests to use updated mock objects
1 parent cabadcf commit 330895a

File tree

2 files changed

+7
-22
lines changed

2 files changed

+7
-22
lines changed

src/pynwb/tests/test_constructors.py

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -246,30 +246,17 @@ def test_constructor_microscopy_response_series():
246246

247247

248248
def test_constructor_microscopy_response_series_with_microscopy_series():
249-
microscope = mock_Microscope()
250-
excitation_light_path = mock_ExcitationLightPath()
251-
planar_imaging_space = mock_PlanarImagingSpace()
252-
emission_light_path = mock_EmissionLightPath()
253249

250+
microscopyrig = mock_MicroscopyRig()
251+
microscopychannel = mock_MicroscopyChannel()
252+
number_of_rois = 10
253+
planar_imaging_space = mock_PlanarImagingSpace()
254254
microscopy_series = mock_PlanarMicroscopySeries(
255-
microscope=microscope,
256-
excitation_light_path=excitation_light_path,
255+
microscopy_channel=microscopychannel,
256+
microscopy_rig=microscopyrig,
257257
planar_imaging_space=planar_imaging_space,
258-
emission_light_path=emission_light_path,
259258
)
260-
# TODO: replace code above with comment below when
261-
# https://github.com/catalystneuro/ndx-microscopy/pull/61 and
262-
# https://github.com/catalystneuro/ndx-microscopy/pull/59 are merged
263-
# microscopyrig = mock_MicroscopyRig()
264-
# microscopychannel = mock_MicroscopyChannel()
265-
# microscopy_series = mock_PlanarMicroscopySeries(
266-
# microscopychannel=microscopychannel,
267-
# microscopyrig=microscopyrig,
268-
# planar_imaging_space=planar_imaging_space,
269-
# )
270-
number_of_rois = 10
271-
planar_imaging_space = mock_PlanarImagingSpace()
272-
segmentation = mock_Segmentation2D(planar_imaging_space=planar_imaging_space, number_of_rois=number_of_rois)
259+
segmentation = mock_PlanarSegmentation(planar_imaging_space=planar_imaging_space, number_of_rois=number_of_rois)
273260
rois = segmentation.create_roi_table_region(
274261
description="test region",
275262
region=[x for x in range(number_of_rois)],

src/pynwb/tests/test_roundtrip.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -354,8 +354,6 @@ def test_roundtrip(self):
354354
class TestMultiChannelMicroscopyContainerSimpleRoundtrip(pynwb_TestCase):
355355
"""Simple roundtrip test for MultiChannelMicroscopyContainer."""
356356

357-
# TODO change to this once MicroscopyRig and MicroscopyChannel are available
358-
359357
def setUp(self):
360358
self.nwbfile_path = "test_multi_channel_microscopy_container_roundtrip.nwb"
361359

0 commit comments

Comments
 (0)