Skip to content

Commit 73626da

Browse files
committed
ICU-22606 Create full release from CI - review feedback
1 parent 3c0d242 commit 73626da

File tree

1 file changed

+16
-3
lines changed

1 file changed

+16
-3
lines changed

.github/README.md

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
## How to create a Fedora docker image
22

3+
For the general process and concepts see:
4+
https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry
5+
6+
For our case I replaced the generic names with our own owner / repo / names / etc.
7+
38
Run
49
```
510
docker login ghcr.io
@@ -8,18 +13,26 @@ docker login ghcr.io
813
When prompted use these:
914

1015
* **User:** the github user
11-
* **Password:** the github key
16+
* **Password:** the github token
1217

1318
Update the timestamp (`20240929`) with the current date, ISO style:
1419
```
1520
docker build --tag ghcr.io/unicode-org/fedora-docker-gcr:20240929 -f Dockerfile_fedora .
1621
docker push ghcr.io/unicode-org/fedora-docker-gcr:20240929
1722
```
1823

19-
See:
24+
For more info see:
2025
https://docs.github.com/en/actions/use-cases-and-examples/publishing-packages/publishing-docker-images
2126

22-
Also:
27+
and:
2328
https://stackoverflow.com/questions/64033686/how-can-i-use-private-docker-image-in-github-actions
2429

2530
To consider: generate and publish the docker image from a GitHub action.
31+
32+
---
33+
34+
The `DOCKER_CONTAINER_USER_NAME` and `DOCKER_CONTAINER_REGISTRY_TOKEN` used
35+
in the action file for user and password are secrets already created.
36+
37+
They can be any GitHub user + token with the proper access rights.
38+
Right now this is a token of the icu-robot account.

0 commit comments

Comments
 (0)