method in configs

Author: max-ostapenko

README.md

@@ -98,6 +98,7 @@ webpagetest --help
 - **-s, --server** _\<server\>_: the WPT server URL [https://www.webpagetest.org]
 - **-d, --dryrun**: just return the RESTful API URL
 - **-o, --out** _\<file\>_: place the output into \<file\>. Defaults to stdout
+- **--http_method** _\<method\>_: the HTTP method to use (GET, POST) [GET]
 
 _The default WPT server can also be specified via environment variable `WEBPAGETEST_SERVER`_
 
@@ -522,6 +523,7 @@ wpt.runTest(script, (err, data) => {
 
 - **dryRun**: _Boolean_, if `true`, method does not make an actual request to the API Server but rather returns an object with `url` which contains the actual URL to make the GET request to WebPageTest API Server
 - **server**: _String_, if specified, overrides the WebPageTest server informed in the constructor only for that method call
+- **http_method**: _String_, if specified, overrides the HTTP method in the constructor only for that method call (GET, POST) [GET]
 
 #### Test (works with `runTest` and `runTestAndWait`)
 

lib/mapping.js

@@ -21,6 +21,10 @@ var options = {
       bool: true,
       info: "just return the RESTful API URL",
     },
+    http_method: {
+      name: "http_method",
+      info: "HTTP method to use for submitting the test (GET or POST) [GET]",
+    }
   },
   test: {
     location: {

lib/webpagetest.js

@@ -19,7 +19,8 @@ var http = require("http"),
 var reSpace = /\s/,
   reConnectivity =
     /^(?:Cable|DSL|3GSlow|3G|3GFast|4G|LTE|Edge|2G|Dial|FIOS|Native|custom)$/,
-  reHTMLOutput = /<h\d[^<]*>([^<]+)<\/h\d>/; // for H3 on cancelTest.php
+  reHTMLOutput = /<h\d[^<]*>([^<]+)<\/h\d>/, // for H3 on cancelTest.php
+  reHTTPmethods = /^(?:GET|POST)$/;
 
 var paths = {
   testStatus: "testStatus.php",
@@ -169,10 +170,10 @@ function get(config, pathname, data, proxy, agent, callback, encoding) {
 
   if (options.method == "POST") {
     return request.end(qs.stringify(data));
-  } else {
-    return request.end();
   }
 
+  return request.end();
+
 }
 
 // execute callback properly normalizing optional args
@@ -202,10 +203,12 @@ function api(pathname, callback, query, options) {
 
   pathname = url.resolve(config.pathname, pathname);
 
-  config.method = url.format({
-    pathname: pathname,
-    query: query,
-  }).toString().length > 6 * 1024 ? "POST" : "GET";
+  if (reHTTPmethods.test(options.http_method)) {
+    config.method = options.http_method;
+  } else {
+    config.method = WebPageTest.defaultHTTPMethod;
+  }
+
 
   if (config.method == "GET") {
     pathname = url.format({
@@ -960,6 +963,7 @@ WebPageTest.filenames = filenames;
 WebPageTest.defaultServer = "https://www.webpagetest.org";
 WebPageTest.defaultListenPort = 7791;
 WebPageTest.defaultWaitResultsPort = 8000;
+WebPageTest.defaultHTTPMethod = "GET";
 
 // Version
 Object.defineProperty(WebPageTest, "version", {

test/edge-cases-test.js

@@ -89,6 +89,7 @@ describe('Edge Cases of', function() {
       wpt.runTest('http://foobar.com', {
         dryRun: true,
         mobile: 1,
+        http_method: 'POST',
         custom: '[example]\n\\\\' + 'X'.repeat(6 * 1024) + '\nreturn 1;'
       }, function (err, data) {
         if (err) return done(err);