switch to new raptorcast packet builder

Author: xinyuan-dev

monad-dataplane/src/udp.rs

@@ -76,7 +76,7 @@ pub const fn segment_size_for_mtu(mtu: u16) -> u16 {
 pub const DEFAULT_SEGMENT_SIZE: u16 = segment_size_for_mtu(DEFAULT_MTU);
 
 const ETHERNET_MTU: u16 = 1500;
-const ETHERNET_SEGMENT_SIZE: u16 = segment_size_for_mtu(ETHERNET_MTU);
+pub const ETHERNET_SEGMENT_SIZE: u16 = segment_size_for_mtu(ETHERNET_MTU);
 
 fn configure_socket(socket: &UdpSocket, buffer_size: Option<usize>) {
     if let Some(size) = buffer_size {

monad-raptor/tests/managed_decoder.rs

@@ -15,7 +15,7 @@
 
 // Tests the managed Raptor decoder.
 
-use monad_raptor::{Encoder, ManagedDecoder};
+use monad_raptor::{Encoder, ManagedDecoder, SOURCE_SYMBOLS_MAX};
 use rand::{prelude::SliceRandom, thread_rng, Rng, RngCore};
 
 const SYMBOL_LEN: usize = 4;
@@ -88,3 +88,10 @@ fn test_invalid_symbol_len() {
 
     decoder.received_encoded_symbol(buf.as_slice(), 0);
 }
+
+#[test]
+fn test_oversized_symbol() {
+    let num_symbols = SOURCE_SYMBOLS_MAX + 1;
+    let decoder = ManagedDecoder::new(num_symbols, num_symbols * 2, SYMBOL_LEN);
+    assert!(decoder.is_err());
+}

monad-raptorcast/benches/encode_bench.rs

@@ -21,7 +21,7 @@ use itertools::Itertools as _;
 use monad_crypto::certificate_signature::{CertificateSignature, CertificateSignaturePubKey};
 use monad_dataplane::udp::DEFAULT_SEGMENT_SIZE;
 use monad_raptorcast::{
-    packet, udp,
+    packet,
     util::{BuildTarget, EpochValidators, Redundancy},
 };
 use monad_secp::SecpSignature;
@@ -56,21 +56,6 @@ pub fn bench_build_messages(c: &mut Criterion, name: &str, message_size: usize,
         _ => panic!("unsupported target"),
     };
 
-    group.bench_function("udp::build_messages", |b| {
-        b.iter(|| {
-            let _ = udp::build_messages(
-                &author,
-                DEFAULT_SEGMENT_SIZE, // segment_size
-                message.clone(),
-                Redundancy::from_u8(2),
-                0, // epoch_no
-                0, // unix_ts_ms
-                build_target.clone(),
-                &known_addrs,
-            );
-        });
-    });
-
     group.bench_function("packet::build_messages", |b| {
         b.iter(|| {
             let _ = packet::build_messages(
@@ -82,7 +67,6 @@ pub fn bench_build_messages(c: &mut Criterion, name: &str, message_size: usize,
                 0, // unix_ts_ms
                 build_target.clone(),
                 &known_addrs,
-                &mut rand::thread_rng(),
             );
         });
     });

monad-raptorcast/benches/raptor_bench.rs

@@ -23,8 +23,8 @@ use monad_crypto::hasher::{Hasher, HasherType};
 use monad_dataplane::udp::DEFAULT_SEGMENT_SIZE;
 use monad_raptor::ManagedDecoder;
 use monad_raptorcast::{
-    packet,
-    udp::{build_messages, parse_message, MAX_REDUNDANCY, SIGNATURE_CACHE_SIZE},
+    packet::build_messages,
+    udp::{parse_message, MAX_REDUNDANCY, SIGNATURE_CACHE_SIZE},
     util::{BuildTarget, EpochValidators, Redundancy},
 };
 use monad_secp::{KeyPair, SecpSignature};
@@ -79,49 +79,6 @@ pub fn criterion_benchmark(c: &mut Criterion) {
         });
     });
 
-    group.bench_function("Encoding (new)", |b| {
-        let keys = (0_u8..100_u8)
-            .map(|n| {
-                let mut hasher = HasherType::new();
-                hasher.update(n.to_le_bytes());
-                let mut hash = hasher.hash();
-                KeyPair::from_bytes(&mut hash.0).unwrap()
-            })
-            .collect_vec();
-
-        let validators = EpochValidators {
-            validators: keys
-                .iter()
-                .map(|key| (NodeId::new(key.pubkey()), Stake::ONE))
-                .collect(),
-        };
-
-        let known_addresses = keys
-            .iter()
-            .map(|key| {
-                (
-                    NodeId::new(key.pubkey()),
-                    SocketAddr::new(IpAddr::V4(Ipv4Addr::LOCALHOST), 0),
-                )
-            })
-            .collect();
-
-        b.iter(|| {
-            let epoch_validators = validators.view_without(vec![&NodeId::new(keys[0].pubkey())]);
-            let _ = packet::build_messages::<SecpSignature>(
-                &keys[0],
-                DEFAULT_SEGMENT_SIZE, // segment_size
-                message.clone(),
-                Redundancy::from_u8(2),
-                0, // epoch_no
-                0, // unix_ts_ms
-                BuildTarget::Raptorcast(epoch_validators),
-                &known_addresses,
-                &mut rand::thread_rng(),
-            );
-        });
-    });
-
     group.bench_function("Decoding", |b| {
         let keys = (0_u8..100_u8)
             .map(|n| {