Collect metrics on chainstate data source #2450
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshulyak
reviewed
Oct 13, 2025
| if let Some(ref source) = data_source { | ||
| wait_attributes.push(KeyValue::new("chainstate_source", source.clone())); | ||
| } | ||
| timing.histogram.record(timing.wait_time, &wait_attributes); |
There was a problem hiding this comment.
i think this looks somewhat hackish, if needed urgently it is probably ok.
i plugged into tracing, so that i can get wait time for async spans, but otherwise spans can be extended with necessary API.
i think i would try to add Span::current().add_extra_timing_label(key, value), that can be accumulated into some array and then exported. impl for add_extra_timing_label should be somewhat similar to update_secondary. there are also tests that can be used to verify that it works as expected
philipglazman
force-pushed
the
pg/chainstate-metrics
branch
from
633aba9 to
7791bbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.