Skip to content

Commit ef09914

Browse files
catlog22claude
andcommitted
fix: Standardize Execution Flow phase naming and remove redundant REVIEW-SUMMARY.md output
- Unify phase numbering format to "Phase X:" across all review workflow commands - Add missing Phase 5: Session Completion to review-fix.md - Replace "Update dashboard" with "Generate fix-dashboard.html" to clarify initialization vs polling - Remove REVIEW-SUMMARY.md generation (dashboard serves as primary output) - Align phase names with Orchestrator section (e.g., "Planning Coordination", "Execution Orchestration") 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 2f4ecf9 commit ef09914

File tree

3 files changed

+27
-26
lines changed

3 files changed

+27
-26
lines changed

.claude/commands/workflow/review-fix.md

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,20 +55,20 @@ Automated fix orchestrator with **two-phase architecture**: AI-powered planning
5555
- Delegates: Fix planning to @cli-planning-agent, fix execution to @cli-execute-agent
5656

5757

58-
### Execution Flow
58+
### Execution Flow
5959

6060
```
61-
1. Discovery & Initialization
61+
Phase 1: Discovery & Initialization
6262
└─ Validate export file, create fix session structure, initialize state files → Generate fix-dashboard.html
6363
64-
2. Phase 2: Planning (@cli-planning-agent):
64+
Phase 2: Planning Coordination (@cli-planning-agent)
6565
├─ Analyze findings for patterns and dependencies
6666
├─ Group by file + dimension + root cause similarity
6767
├─ Determine execution strategy (parallel/serial/hybrid)
6868
├─ Generate fix timeline with stages
6969
└─ Output: fix-plan.json (dashboard auto-polls for status)
7070
71-
3. Phase 3: Execution (Stage-based):
71+
Phase 3: Execution Orchestration (Stage-based)
7272
For each timeline stage:
7373
├─ Load groups for this stage
7474
├─ If parallel: Launch all group agents simultaneously
@@ -81,8 +81,11 @@ Automated fix orchestrator with **two-phase architecture**: AI-powered planning
8181
│ └─ On success: Commit, update fix-progress-{N}.json
8282
└─ Advance to next stage
8383
84-
4. Phase 4: Completion
84+
Phase 4: Completion & Aggregation
8585
└─ Aggregate results → Generate fix-summary.md → Update history → Output summary
86+
87+
Phase 5: Session Completion (Optional)
88+
└─ If all fixes successful → Prompt to complete workflow session
8689
```
8790

8891
### Agent Roles

.claude/commands/workflow/review-module-cycle.md

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -62,35 +62,35 @@ Independent multi-dimensional code review orchestrator with **hybrid parallel-it
6262

6363
## How It Works
6464

65-
### Execution Flow
65+
### Execution Flow
6666

6767
```
68-
1. Discovery & Initialization
68+
Phase 1: Discovery & Initialization
6969
└─ Resolve file patterns, validate paths, initialize state, create output structure → Generate dashboard.html
7070
71-
2. Phase 2: Parallel Reviews (for each dimension):
71+
Phase 2: Parallel Reviews (for each dimension)
7272
├─ Launch 7 review agents simultaneously
7373
├─ Each executes CLI analysis via Gemini/Qwen on specified files
7474
├─ Generate dimension JSON + markdown reports
7575
└─ Update review-progress.json
7676
77-
3. Phase 3: Aggregation:
77+
Phase 3: Aggregation
7878
├─ Load all dimension JSON files
7979
├─ Calculate severity distribution (critical/high/medium/low)
8080
├─ Identify cross-cutting concerns (files in 3+ dimensions)
8181
└─ Decision:
8282
├─ Critical findings OR high > 5 OR critical files → Phase 4 (Iterate)
8383
└─ Else → Phase 5 (Complete)
8484
85-
4. Phase 4: Iterative Deep-Dive (optional):
85+
Phase 4: Iterative Deep-Dive (optional)
8686
├─ Select critical findings (max 5 per iteration)
8787
├─ Launch deep-dive agents for root cause analysis
8888
├─ Generate remediation plans with impact assessment
8989
├─ Re-assess severity based on analysis
9090
└─ Loop until no critical findings OR max iterations
9191
92-
5. Phase 5: Completion
93-
└─ Generate REVIEW-SUMMARY.md → Output path
92+
Phase 5: Completion
93+
└─ Finalize review-progress.json → Output dashboard path
9494
```
9595

9696
### Agent Roles
@@ -274,10 +274,10 @@ echo "📊 Dashboard: file://$(cd ${sessionDir} && pwd)/.review/dashboard.html"
274274
- Loop back to aggregation if still have critical/high findings
275275

276276
**Phase 5: Completion**
277-
- Generate REVIEW-SUMMARY.md with all findings and statistics
277+
- Finalize review-progress.json with completion statistics
278278
- Update review-state.json with completion_time and phase=complete
279279
- TodoWrite completion: Mark all tasks done
280-
- Output: Dashboard path and REVIEW-SUMMARY.md path to user
280+
- Output: Dashboard path to user
281281

282282

283283

@@ -303,8 +303,7 @@ echo "📊 Dashboard: file://$(cd ${sessionDir} && pwd)/.review/dashboard.html"
303303
│ ├── security-cli-output.txt
304304
│ ├── deep-dive-1-{uuid}.md
305305
│ └── ...
306-
├── REVIEW-SUMMARY.md # Final summary
307-
└── dashboard.html # Interactive dashboard
306+
└── dashboard.html # Interactive dashboard (primary output)
308307
```
309308

310309
**Session Context**:

.claude/commands/workflow/review-session-cycle.md

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,32 +58,32 @@ Session-based multi-dimensional code review orchestrator with **hybrid parallel-
5858
### Execution Flow (Simplified)
5959

6060
```
61-
1. Discovery & Initialization
61+
Phase 1: Discovery & Initialization
6262
└─ Validate session, initialize state, create output structure → Generate dashboard.html
6363
64-
2. Phase 2: Parallel Reviews (for each dimension):
64+
Phase 2: Parallel Reviews (for each dimension)
6565
├─ Launch 7 review agents simultaneously
6666
├─ Each executes CLI analysis via Gemini/Qwen
6767
├─ Generate dimension JSON + markdown reports
6868
└─ Update review-progress.json
6969
70-
3. Phase 3: Aggregation:
70+
Phase 3: Aggregation
7171
├─ Load all dimension JSON files
7272
├─ Calculate severity distribution (critical/high/medium/low)
7373
├─ Identify cross-cutting concerns (files in 3+ dimensions)
7474
└─ Decision:
7575
├─ Critical findings OR high > 5 OR critical files → Phase 4 (Iterate)
7676
└─ Else → Phase 5 (Complete)
7777
78-
4. Phase 4: Iterative Deep-Dive (optional):
78+
Phase 4: Iterative Deep-Dive (optional)
7979
├─ Select critical findings (max 5 per iteration)
8080
├─ Launch deep-dive agents for root cause analysis
8181
├─ Generate remediation plans with impact assessment
8282
├─ Re-assess severity based on analysis
8383
└─ Loop until no critical findings OR max iterations
8484
85-
5. Phase 5: Completion
86-
└─ Generate REVIEW-SUMMARY.md → Output path
85+
Phase 5: Completion
86+
└─ Finalize review-progress.json → Output dashboard path
8787
```
8888

8989
### Agent Roles
@@ -254,10 +254,10 @@ echo "📊 Dashboard: file://$(cd ${sessionDir} && pwd)/.review/dashboard.html"
254254
- Loop back to aggregation if still have critical/high findings
255255

256256
**Phase 5: Completion**
257-
- Generate REVIEW-SUMMARY.md with all findings and statistics
257+
- Finalize review-progress.json with completion statistics
258258
- Update review-state.json with completion_time and phase=complete
259259
- TodoWrite completion: Mark all tasks done
260-
- Output: Dashboard path and REVIEW-SUMMARY.md path to user
260+
- Output: Dashboard path to user
261261

262262

263263

@@ -283,8 +283,7 @@ echo "📊 Dashboard: file://$(cd ${sessionDir} && pwd)/.review/dashboard.html"
283283
│ ├── security-cli-output.txt
284284
│ ├── deep-dive-1-{uuid}.md
285285
│ └── ...
286-
├── REVIEW-SUMMARY.md # Final summary
287-
└── dashboard.html # Interactive dashboard
286+
└── dashboard.html # Interactive dashboard (primary output)
288287
```
289288

290289
**Session Context**:

0 commit comments

Comments
 (0)