Skip to content

Commit 8d16282

Browse files
authored
Merge pull request apache#442 from ztonny/master
[Bug] fix issue apache#441 use clearErr not reconErr when clearUnusedResources() returned
2 parents 09aca41 + 252aee8 commit 8d16282

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

pkg/controller/disaggregated_cluster_controller.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ import (
2121
"context"
2222
"errors"
2323
"fmt"
24+
"os"
25+
"time"
26+
2427
dv1 "github.com/apache/doris-operator/api/disaggregated/v1"
2528
"github.com/apache/doris-operator/pkg/common/utils/hash"
2629
sc "github.com/apache/doris-operator/pkg/controller/sub_controller"
@@ -35,15 +38,13 @@ import (
3538
"k8s.io/client-go/tools/record"
3639
"k8s.io/client-go/util/retry"
3740
"k8s.io/klog/v2"
38-
"os"
3941
ctrl "sigs.k8s.io/controller-runtime"
4042
controller_builder "sigs.k8s.io/controller-runtime/pkg/builder"
4143
"sigs.k8s.io/controller-runtime/pkg/client"
4244
"sigs.k8s.io/controller-runtime/pkg/event"
4345
"sigs.k8s.io/controller-runtime/pkg/handler"
4446
"sigs.k8s.io/controller-runtime/pkg/predicate"
4547
"sigs.k8s.io/controller-runtime/pkg/reconcile"
46-
"time"
4748
)
4849

4950
var (
@@ -214,7 +215,7 @@ func (dc *DisaggregatedClusterReconciler) Reconcile(ctx context.Context, req rec
214215
// clear unused resources.
215216
clearRes, clearErr := dc.clearUnusedResources(ctx, &ddc)
216217
if clearErr != nil {
217-
msg = msg + reconErr.Error()
218+
msg = msg + clearErr.Error()
218219
}
219220

220221
if !clearRes.IsZero() {
@@ -344,7 +345,7 @@ func (dc *DisaggregatedClusterReconciler) updateObjectORStatus(ctx context.Conte
344345

345346
}
346347

347-
func(dc *DisaggregatedClusterReconciler) clearReconcileAnnotations(ddc *dv1.DorisDisaggregatedCluster) {
348+
func (dc *DisaggregatedClusterReconciler) clearReconcileAnnotations(ddc *dv1.DorisDisaggregatedCluster) {
348349
if len(ddc.Annotations) == 0 {
349350
return
350351
}

0 commit comments

Comments
 (0)