Remove [light] and [dark] sections from themes, add Latte theme

[sollniss]

Currently the [light] section for all variants (Frappe, Macciato, Mocha) is identical (I'm assuming Latte). The default behaviour should be applying "Mocha" if I have selected "Mocha" as a theme, independent of whether my global setting is light or dark.

Besides that, the current themes produce an error when the global mode is unreported by the terminal:

fish_config theme choose: failed to find '[unknown]' section (implied by $fish_terminal_color_theme) in 'Catppuccin Mocha' theme
fish_config theme choose: hint: if your terminal does not report colors, pass --color-theme=light or --color-theme=dark when using color-theme-aware themes

The error above is produced by WezTerm (Windows) opening the fish shell inside of WSL (NixOS).

Setting all values at the top level (without dark/light sections) would solve both problems. Refer to the default theme here for an example.

This basically means reverting #30.

[helenclx]

What is the version number of your fish shell?

Catppuccin's fish port now ships dynamic themes, with Latte as the light variant in all themes, because fish has started to support dynamic themes since 4.3.

As stated in the repository README's FAQ section:

• Q: Where's the Latte theme?
  A: All three themes contain Latte as the light variant. Install any of them, and then set your system or terminal theme to light mode.

If you only want the dark variant of a Catppuccin theme, regardless if your global setting is light or dark, you can try to add a --color-theme=dark flag to your theme choice in your fish config:

fish_config theme choose "Catppuccin Mocha" --color-theme=dark

[sollniss]

I'm on version 4.3.3. I'm proposing that the default should be the opposite:

• If I set Mocha as a theme, then I expect the theme to be Mocha always, not Mocha in dark mode, Latte in light mode and an error if unknown.
• If users want dynamic theming they are free to make a theme which has Mocha values in [dark] and Latte values in [light]

What do you think about renaming the current themes to "Mocha/Latte", "Macciato/Latte" and "Frappe/Latte" and generate static themes with the current names, including a static one for Latte. That would make everyone happy I believe?

The current default behaviour just seems very unexpected to me. Catppuccin themes are not dynamic (Mocha does not change in light mode).

[musjj]

I'm also getting the warning message on Ghostty. Is there some kind of terminal protocol that Ghostty and Wezterm is missing that is causing this warning?

[sollniss]

FWIW, I only get the warning on Windows Wezterm opening fish in WSL. When I try it on a NixOS machine I get no warning.

[backwardspy]

i'm working on providing some options on the feat/static-themes branch. this includes a better explanation of how to use the dynamic themes (namely how to opt-out of the color scheme detection), as well as the old-style static themes for older fish versions. let me know what you think.

this will eventually make it to main, but it's using an unreleased whiskers feature so i'm holding off until i get that finished & released.

cheers!

[sollniss]

Nice, looks good to me. Thank you!

This would simplify the catppuccin/nix implementation as well, since we can just use the static versions.

I haven't tried it, but looking at the warning, it seems to me that including an [unknown] section with the same content as the [dark] one would fix Wezterm and Ghostty as well.

[backwardspy]

ah i hadn't seen the [unknown] heading, that's a good idea. thanks for pointing it out!

edit: added 👍

[kiriwalawren]

Is this the cause of why the status line doesn't seem to be working? Or is that a different issue?

Edit: I'm using catppucin/nix by the way.

[sollniss]

Not sure tbh. What is printed when you do

echo $fish_terminal_color_theme

?

[kiriwalawren]

This is my config. I removed the aliases for brevity.

# ~/.config/fish/config.fish: DO NOT EDIT -- this file has been generated
# automatically by home-manager.

# Only execute this file once per shell.
set -q __fish_home_manager_config_sourced; and exit
set -g __fish_home_manager_config_sourced 1

source /nix/store/iqhmjgdz1wnq67z5kplll54ilmfpfjmp-hm-session-vars.fish/etc/profile.d/hm-session-vars.fish

fish_config theme choose "Catppuccin Mocha"

set fish_greeting # Disable greeting
set hydro_color_pwd $fish_color_cwd
set hydro_color_git $fish_color_host
set hydro_color_prompt $fish_color_host_remote
fish_vi_key_bindings

eval (/nix/store/i2vmgx46q9hd3z6rigaiman3wl3i2gc4-coreutils-9.9/bin/dircolors -c ~/.dir_colors)

status is-login; and begin

    # Login shell initialisation

end

status is-interactive; and begin


    # Interactive shell initialisation
    /nix/store/98zgrv8ghd6dzqyc8qiral5vik844r17-fzf-0.67.0/bin/fzf --fish | source

    if set -q KITTY_INSTALLATION_DIR
        set --global KITTY_SHELL_INTEGRATION no-rc
        source "$KITTY_INSTALLATION_DIR/shell-integration/fish/vendor_conf.d/kitty-shell-integration.fish"
        set --prepend fish_complete_path "$KITTY_INSTALLATION_DIR/shell-integration/fish/vendor_completions.d"
    end

    # add completions generated by Home Manager to $fish_complete_path
    begin
        set -l joined (string join " " $fish_complete_path)
        set -l prev_joined (string replace --regex "[^\s]*generated_completions.*" "" $joined)
        set -l post_joined (string replace $prev_joined "" $joined)
        set -l prev (string split " " (string trim $prev_joined))
        set -l post (string split " " (string trim $post_joined))
        set fish_complete_path $prev "/home/walawren/.local/share/fish/home-manager/generated_completions" $post
    end

    /nix/store/aqm6npczf3rnavcxihwvz7c8r6i6dw9q-direnv-2.37.1/bin/direnv hook fish | source

end

[sollniss]

If it prints "dark", it should work properly, as far as I understand. Your problem might be caused by something else. You could wait until the changes hit nix, or you could try applying it locally if you can't wait, just to doublecheck.